Commit d05ca13b authored Dec 21, 2017 by Thomas Gleixner Committed by Ingo Molnar Jan 16, 2018

hrtimer: Correct blatantly incorrect comment



The protection of a hrtimer which runs its callback against migration to a
different CPU has nothing to do with hard interrupt context.

The protection against migration of a hrtimer running the expiry callback
is the pointer in the cpu_base which holds a pointer to the currently
running timer. This pointer is evaluated in the code which potentially
switches the timer base and makes sure it's kept on the CPU on which the
callback is running.

Reported-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: keescook@chromium.org
Link: http://lkml.kernel.org/r/20171221104205.7269-3-anna-maria@linutronix.de


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent ae67bada

kernel/time/hrtimer.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1195,9 +1195,9 @@ static void __run_hrtimer(struct hrtimer_cpu_base *cpu_base,
		timer->is_rel = false;

		/*
		* Because we run timers from hardirq context, there is no chance
		* they get migrated to another cpu, therefore its safe to unlock
		* the timer base.
		* The timer is marked as running in the CPU base, so it is
		* protected against migration to a different CPU even if the lock
		* is dropped.
		*/
		raw_spin_unlock(&cpu_base->lock);
		trace_hrtimer_expire_entry(timer, now);

Admin message