Commit d053de91 authored by Ajit Khaparde's avatar Ajit Khaparde Committed by David S. Miller
Browse files

be2net: fix a bug in UE detection logic 



The ONLINE registers can return 0xFFFFFFFF on more than one
occassion. On systems that care, reading these registers could
lead to problems.

So the new code decides that the ASIC has encountered and error
by reading the UE_STATUS_LOW/HIGH registers. AND them with
the mask values and a non-zero result indicates an error.

Signed-off-by: default avatarAjit Khaparde <ajitk@serverengines.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1ef78abe

drivers/net/benet/be_cmds.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static int be_mbox_db_ready_wait(struct be_adapter *adapter, void __iomem *db) 


		if (msecs > 4000) {

			dev_err(&adapter->pdev->dev, "mbox poll timed out\n");

			be_dump_ue(adapter);

			be_detect_dump_ue(adapter);

			return -1;

		}

drivers/net/benet/be_cmds.h

+1 −1
Original line number Diff line number Diff line
@@ -992,5 +992,5 @@ extern int be_cmd_set_loopback(struct be_adapter *adapter, u8 port_num, 
extern int be_cmd_get_phy_info(struct be_adapter *adapter,

		struct be_dma_mem *cmd);

extern int be_cmd_set_qos(struct be_adapter *adapter, u32 bps, u32 domain);

extern void be_dump_ue(struct be_adapter *adapter);

extern void be_detect_dump_ue(struct be_adapter *adapter);

drivers/net/benet/be_main.c

+8 −24
Original line number Diff line number Diff line
@@ -1750,26 +1750,7 @@ static int be_poll_tx_mcc(struct napi_struct *napi, int budget) 
	return 1;

}



static inline bool be_detect_ue(struct be_adapter *adapter)

{

	u32 online0 = 0, online1 = 0;



	pci_read_config_dword(adapter->pdev, PCICFG_ONLINE0, &online0);



	pci_read_config_dword(adapter->pdev, PCICFG_ONLINE1, &online1);



	if (!online0 || !online1) {

		adapter->ue_detected = true;

		dev_err(&adapter->pdev->dev,

			"UE Detected!! online0=%d online1=%d\n",

			online0, online1);

		return true;

	}



	return false;

}



void be_dump_ue(struct be_adapter *adapter)

void be_detect_dump_ue(struct be_adapter *adapter)

{

	u32 ue_status_lo, ue_status_hi, ue_status_lo_mask, ue_status_hi_mask;

	u32 i;
@@ -1786,6 +1767,11 @@ void be_dump_ue(struct be_adapter *adapter) 
	ue_status_lo = (ue_status_lo & (~ue_status_lo_mask));

	ue_status_hi = (ue_status_hi & (~ue_status_hi_mask));



	if (ue_status_lo || ue_status_hi) {

		adapter->ue_detected = true;

		dev_err(&adapter->pdev->dev, "UE Detected!!\n");

	}



	if (ue_status_lo) {

		for (i = 0; ue_status_lo; ue_status_lo >>= 1, i++) {

			if (ue_status_lo & 1)
@@ -1821,10 +1807,8 @@ static void be_worker(struct work_struct *work) 
		adapter->rx_post_starved = false;

		be_post_rx_frags(adapter);

	}

	if (!adapter->ue_detected) {

		if (be_detect_ue(adapter))

			be_dump_ue(adapter);

	}

	if (!adapter->ue_detected)

		be_detect_dump_ue(adapter);



	schedule_delayed_work(&adapter->work, msecs_to_jiffies(1000));

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE