Commit d04a78f4 authored by Denys Vlasenko's avatar Denys Vlasenko Committed by Martin K. Petersen
Browse files

bfa: deinline __bfa_trc() and __bfa_trc32() 

__bfa_trc() compiles to 115 bytes of machine code.
With this .config: http://busybox.net/~vda/kernel_config


there are 1494 calls of __bfa_trc().

__bfa_trc32() is very similar, so it is uninlined too.
However, it appears to be unused, therefore this patch
ifdefs it out.

Change in code size is about 130,000 bytes:

    text     data      bss       dec     hex filename
85975426 22294712 20627456 128897594 7aed23a vmlinux.before
85842882 22294584 20627456 128764922 7accbfa vmlinux

[mkp: Removed unused __bfa_trc32()]

Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
Acked-by: default avatarAnil Gurumurthy <anil.gurumurthy@qlogic.com>
CC: Fabian Frederick <fabf@skynet.be>
CC: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
CC: Christoph Hellwig <hch@lst.de>
CC: Guenter Roeck <linux@roeck-us.net>
CC: Ben Hutchings <ben@decadent.org.uk>
CC: James Bottomley <JBottomley@Parallels.com>
CC: linux-kernel@vger.kernel.org
CC: linux-scsi@vger.kernel.org
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9d7ab5aa

drivers/scsi/bfa/bfa_core.c

+19 −0
Original line number Diff line number Diff line
@@ -91,6 +91,25 @@ static bfa_ioc_mbox_mcfunc_t bfa_mbox_isrs[BFI_MC_MAX] = { 






void

__bfa_trc(struct bfa_trc_mod_s *trcm, int fileno, int line, u64 data)

{

	int		tail = trcm->tail;

	struct bfa_trc_s	*trc = &trcm->trc[tail];



	if (trcm->stopped)

		return;



	trc->fileno = (u16) fileno;

	trc->line = (u16) line;

	trc->data.u64 = data;

	trc->timestamp = BFA_TRC_TS(trcm);



	trcm->tail = (trcm->tail + 1) & (BFA_TRC_MAX - 1);

	if (trcm->tail == trcm->head)

		trcm->head = (trcm->head + 1) & (BFA_TRC_MAX - 1);

}



static void

bfa_com_port_attach(struct bfa_s *bfa)

{

drivers/scsi/bfa/bfa_cs.h

+4 −37
Original line number Diff line number Diff line
@@ -108,44 +108,11 @@ bfa_trc_stop(struct bfa_trc_mod_s *trcm) 
	trcm->stopped = 1;

}



static inline void

__bfa_trc(struct bfa_trc_mod_s *trcm, int fileno, int line, u64 data)

{

	int		tail = trcm->tail;

	struct bfa_trc_s	*trc = &trcm->trc[tail];



	if (trcm->stopped)

		return;



	trc->fileno = (u16) fileno;

	trc->line = (u16) line;

	trc->data.u64 = data;

	trc->timestamp = BFA_TRC_TS(trcm);



	trcm->tail = (trcm->tail + 1) & (BFA_TRC_MAX - 1);

	if (trcm->tail == trcm->head)

		trcm->head = (trcm->head + 1) & (BFA_TRC_MAX - 1);

}



void

__bfa_trc(struct bfa_trc_mod_s *trcm, int fileno, int line, u64 data);



static inline void

__bfa_trc32(struct bfa_trc_mod_s *trcm, int fileno, int line, u32 data)

{

	int		tail = trcm->tail;

	struct bfa_trc_s *trc = &trcm->trc[tail];



	if (trcm->stopped)

		return;



	trc->fileno = (u16) fileno;

	trc->line = (u16) line;

	trc->data.u32.u32 = data;

	trc->timestamp = BFA_TRC_TS(trcm);



	trcm->tail = (trcm->tail + 1) & (BFA_TRC_MAX - 1);

	if (trcm->tail == trcm->head)

		trcm->head = (trcm->head + 1) & (BFA_TRC_MAX - 1);

}

void

__bfa_trc32(struct bfa_trc_mod_s *trcm, int fileno, int line, u32 data);



#define bfa_sm_fault(__mod, __event)	do {				\

	bfa_trc(__mod, (((u32)0xDEAD << 16) | __event));		\

CRA Git | Maintained and supported by SUSTech CRA and CCSE