Commit d03213f1 authored Jan 09, 2019 by Hongye Yuan Committed by Benjamin Tissoires Jan 09, 2019

HID: sony: Fix SHANWAN PS3 GamePad rumble and led settings support



Rumble support on SHANWAN PS3 gamepad is not working when a user
program has asked it to. If a HID Output Reports is sent via Control
Channel then it will be discard by gamepad, thus rumble motor and led
settings in Output Report are ignored.

This patch therefore sends HID Output Report via Interrupt Channel to
SHANWAN gamepad instead of Control Channel, fixing rumble motor and
led settings.

Signed-off-by: Hongye Yuan <outmatch@gmail.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

parent 69481059

drivers/hid/hid-sony.c

+8 −3

Original line number	Original line	Diff line number	Diff line
	@@ -2100,6 +2100,11 @@ static void sixaxis_send_output_report(struct sony_sc *sc)
	}		}
	}		}

			/* SHANWAN controllers require output reports via intr channel */
			if (sc->quirks & SHANWAN_GAMEPAD)
			hid_hw_output_report(sc->hdev, (u8 *)report,
			sizeof(struct sixaxis_output_report));
			else
	hid_hw_raw_request(sc->hdev, report->report_id, (u8 *)report,		hid_hw_raw_request(sc->hdev, report->report_id, (u8 *)report,
	sizeof(struct sixaxis_output_report),		sizeof(struct sixaxis_output_report),
	HID_OUTPUT_REPORT, HID_REQ_SET_REPORT);		HID_OUTPUT_REPORT, HID_REQ_SET_REPORT);

Admin message