Commit d0121b85 authored Jul 11, 2018 by Wolfram Sang Committed by Linus Walleij Sep 14, 2018

gpiolib: use better errno if get_direction is not available



EINVAL is very generic, use ENOTSUPP in case the gpiochip does not
provide this function. While removing the assignment from the 'status'
variable, use better indentation in the declaration block.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent fa38869b

drivers/gpio/gpiolib.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -212,13 +212,13 @@ int gpiod_get_direction(struct gpio_desc *desc)
		{
		struct gpio_chip *chip;
		unsigned offset;
		int status = -EINVAL;
		int status;

		chip = gpiod_to_chip(desc);
		offset = gpio_chip_hwgpio(desc);

		if (!chip->get_direction)
		return status;
		return -ENOTSUPP;

		status = chip->get_direction(chip, offset);
		if (status > 0) {

Admin message