Commit cff10ce7 authored by Johan Hedberg's avatar Johan Hedberg Committed by Marcel Holtmann
Browse files

Bluetooth: Fix incorrect removing of IRKs 



The commit cad20c27 was supposed to
fix handling of devices first using public addresses and then
switching to RPAs after pairing. Unfortunately it missed a couple of
key places in the code.

1. When evaluating which devices should be removed from the existing
white list we also need to consider whether we have an IRK for them or
not, i.e. a call to hci_find_irk_by_addr() is needed.

2. In smp_notify_keys() we should not be requiring the knowledge of
the RPA, but should simply keep the IRK around if the other conditions
require it.

Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org # 4.4+
parent a2342c5f

net/bluetooth/hci_request.c

+18 −10
Original line number Diff line number Diff line
@@ -688,21 +688,29 @@ static u8 update_white_list(struct hci_request *req) 
	 * command to remove it from the controller.

	 */

	list_for_each_entry(b, &hdev->le_white_list, list) {

		struct hci_cp_le_del_from_white_list cp;



		if (hci_pend_le_action_lookup(&hdev->pend_le_conns,

					      &b->bdaddr, b->bdaddr_type) ||

		    hci_pend_le_action_lookup(&hdev->pend_le_reports,

		/* If the device is neither in pend_le_conns nor

		 * pend_le_reports then remove it from the whitelist.

		 */

		if (!hci_pend_le_action_lookup(&hdev->pend_le_conns,

					       &b->bdaddr, b->bdaddr_type) &&

		    !hci_pend_le_action_lookup(&hdev->pend_le_reports,

					       &b->bdaddr, b->bdaddr_type)) {

			white_list_entries++;

			continue;

		}

			struct hci_cp_le_del_from_white_list cp;



			cp.bdaddr_type = b->bdaddr_type;

			bacpy(&cp.bdaddr, &b->bdaddr);



			hci_req_add(req, HCI_OP_LE_DEL_FROM_WHITE_LIST,

				    sizeof(cp), &cp);

			continue;

		}



		if (hci_find_irk_by_addr(hdev, &b->bdaddr, b->bdaddr_type)) {

			/* White list can not be used with RPAs */

			return 0x00;

		}



		white_list_entries++;

	}



	/* Since all no longer valid white list entries have been

net/bluetooth/smp.c

+0 −16
Original line number Diff line number Diff line
@@ -1072,22 +1072,6 @@ static void smp_notify_keys(struct l2cap_conn *conn) 
			hcon->dst_type = smp->remote_irk->addr_type;

			queue_work(hdev->workqueue, &conn->id_addr_update_work);

		}



		/* When receiving an indentity resolving key for

		 * a remote device that does not use a resolvable

		 * private address, just remove the key so that

		 * it is possible to use the controller white

		 * list for scanning.

		 *

		 * Userspace will have been told to not store

		 * this key at this point. So it is safe to

		 * just remove it.

		 */

		if (!bacmp(&smp->remote_irk->rpa, BDADDR_ANY)) {

			list_del_rcu(&smp->remote_irk->list);

			kfree_rcu(smp->remote_irk, rcu);

			smp->remote_irk = NULL;

		}

	}



	if (smp->csrk) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE