Commit cfef67f0 authored Aug 09, 2019 by Wenwen Wang Committed by Takashi Iwai Aug 10, 2019

ALSA: hda - Fix a memory leak bug



In snd_hda_parse_generic_codec(), 'spec' is allocated through kzalloc().
Then, the pin widgets in 'codec' are parsed. However, if the parsing
process fails, 'spec' is not deallocated, leading to a memory leak.

To fix the above issue, free 'spec' before returning the error.

Fixes: 352f7f91 ("ALSA: hda - Merge Realtek parser code to generic parser")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent de768ce4

sound/pci/hda/hda_generic.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6100,7 +6100,7 @@ static int snd_hda_parse_generic_codec(struct hda_codec *codec)

		err = snd_hda_parse_pin_defcfg(codec, &spec->autocfg, NULL, 0);
		if (err < 0)
		return err;
		goto error;

		err = snd_hda_gen_parse_auto_config(codec, &spec->autocfg);
		if (err < 0)

Admin message