Commit cfc43519 authored Nov 28, 2018 by Pan Bian Committed by David S. Miller Nov 28, 2018

rapidio/rionet: do not free skb before reading its length



skb is freed via dev_kfree_skb_any, however, skb->len is read then. This
may result in a use-after-free bug.

Fixes: e6161d64 ("rapidio/rionet: rework driver initialization and removal")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4df5ce9b

drivers/net/rionet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -216,9 +216,9 @@ static int rionet_start_xmit(struct sk_buff skb, struct net_device ndev)
		* it just report sending a packet to the target
		* (without actual packet transfer).
		*/
		dev_kfree_skb_any(skb);
		ndev->stats.tx_packets++;
		ndev->stats.tx_bytes += skb->len;
		dev_kfree_skb_any(skb);
		}
		}

Admin message