Commit cfc03118 authored Apr 23, 2013 by Joonsoo Kim Committed by Ingo Molnar Apr 24, 2013

sched: Don't consider other cpus in our group in case of NEWLY_IDLE



Commit 88b8dac0 makes load_balance() consider other cpus in its
group, regardless of idle type. When we do NEWLY_IDLE balancing,
we should not consider it, because a motivation of NEWLY_IDLE
balancing is to turn this cpu to non idle state if needed. This
is not the case of other cpus. So, change code not to consider
other cpus for NEWLY_IDLE balancing.

With this patch, assign 'if (pulled_task) this_rq->idle_stamp =
0' in idle_balance() is corrected, because NEWLY_IDLE balancing
doesn't consider other cpus. Assigning to 'this_rq->idle_stamp'
is now valid.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Tested-by: Jason Low <jason.low2@hp.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Cc: Davidlohr Bueso <davidlohr.bueso@hp.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1366705662-3587-4-git-send-email-iamjoonsoo.kim@lge.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent de5eb2dd

kernel/sched/fair.c

+14 −1

Original line number	Diff line number	Diff line
		@@ -5026,9 +5026,22 @@ static int load_balance(int this_cpu, struct rq *this_rq,
		.cpus = cpus,
		};

		cpumask_copy(cpus, cpu_active_mask);
		/*
		* For NEWLY_IDLE load_balancing, we don't need to consider
		* other cpus in our group
		*/
		if (idle == CPU_NEWLY_IDLE) {
		env.dst_grpmask = NULL;
		/*
		* we don't care max_lb_iterations in this case,
		* in following patch, this will be removed
		*/
		max_lb_iterations = 0;
		} else
		max_lb_iterations = cpumask_weight(env.dst_grpmask);

		cpumask_copy(cpus, cpu_active_mask);

		schedstat_inc(sd, lb_count[idle]);

		redo:

Admin message