USB: visor: fix initialisation of UX50/TH55 devices (cfb8da8f) · Commits · 戴 / test

Fix regression introduced by commit (USB: visor: reimplement using generic framework) which broke initialisation of UX50/TH55 devices that used re-mapped bulk-out endpoint addresses. Reported-by:

Robert Gadsdon <rgadsdon@bayarea.net> Tested-by:

Robert Gadsdon <rgadsdon@bayarea.net> Cc: stable <stable@kernel.org> Signed-off-by:

Johan Hovold <jhovold@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@suse.de>

drivers/usb/serial/visor.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -606,6 +606,10 @@ static int treo_attach(struct usb_serial *serial)

		static int clie_5_attach(struct usb_serial *serial)
		{
		struct usb_serial_port *port;
		unsigned int pipe;
		int j;

		dbg("%s", __func__);

		/* TH55 registers 2 ports.
		@@ -621,9 +625,14 @@ static int clie_5_attach(struct usb_serial *serial)
		return -1;

		/* port 0 now uses the modified endpoint Address */
		serial->port[0]->bulk_out_endpointAddress =
		port = serial->port[0];
		port->bulk_out_endpointAddress =
		serial->port[1]->bulk_out_endpointAddress;

		pipe = usb_sndbulkpipe(serial->dev, port->bulk_out_endpointAddress);
		for (j = 0; j < ARRAY_SIZE(port->write_urbs); ++j)
		port->write_urbs[j]->pipe = pipe;

		return 0;
		}

Admin message