Commit cfb32101 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Greg Kroah-Hartman
Browse files

slimbus: core: do not call device_status under a lock 



Calling device_status callback under a lock would prevent drivers
to do any slimbus trasactions which would invoke this lock like
get_laddr(). Remove this unnecessary lock!

Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8631f940

drivers/slimbus/core.c

+3 −0
Original line number Diff line number Diff line
@@ -466,6 +466,7 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev, 


	sbdev->laddr = laddr;

	sbdev->is_laddr_valid = true;

	mutex_unlock(&ctrl->lock);



	slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP);
@@ -473,6 +474,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev, 
		laddr, sbdev->e_addr.manf_id, sbdev->e_addr.prod_code,

		sbdev->e_addr.dev_index, sbdev->e_addr.instance);



	return 0;



err:

	mutex_unlock(&ctrl->lock);

	return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE