Commit cfad392b authored by Josef Bacik's avatar Josef Bacik Committed by Chris Mason
Browse files

Btrfs: check to see if root_list is empty before adding it to dead roots 



A user reported a panic when running with autodefrag and deleting snapshots.
This is because we could end up trying to add the root to the dead roots list
twice.  To fix this check to see if we are empty before adding ourselves to the
dead roots list.  Thanks,

Signed-off-by: default avatarJosef Bacik <jbacik@fusionio.com>
Signed-off-by: default avatarChris Mason <chris.mason@fusionio.com>
parent f3b15ccd

fs/btrfs/transaction.c

+4 −4
Original line number Diff line number Diff line
@@ -983,12 +983,12 @@ static noinline int commit_cowonly_roots(struct btrfs_trans_handle *trans, 
 * a dirty root struct and adds it into the list of dead roots that need to

 * be deleted

 */

int btrfs_add_dead_root(struct btrfs_root *root)

void btrfs_add_dead_root(struct btrfs_root *root)

{

	spin_lock(&root->fs_info->trans_lock);

	if (list_empty(&root->root_list))

		list_add_tail(&root->root_list, &root->fs_info->dead_roots);

	spin_unlock(&root->fs_info->trans_lock);

	return 0;

}



/*
@@ -1925,7 +1925,7 @@ int btrfs_clean_one_deleted_snapshot(struct btrfs_root *root) 
	}

	root = list_first_entry(&fs_info->dead_roots,

			struct btrfs_root, root_list);

	list_del(&root->root_list);

	list_del_init(&root->root_list);

	spin_unlock(&fs_info->trans_lock);



	pr_debug("btrfs: cleaner removing %llu\n",

fs/btrfs/transaction.h

+1 −1
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ int btrfs_wait_for_commit(struct btrfs_root *root, u64 transid); 
int btrfs_write_and_wait_transaction(struct btrfs_trans_handle *trans,

				     struct btrfs_root *root);



int btrfs_add_dead_root(struct btrfs_root *root);

void btrfs_add_dead_root(struct btrfs_root *root);

int btrfs_defrag_root(struct btrfs_root *root);

int btrfs_clean_one_deleted_snapshot(struct btrfs_root *root);

int btrfs_commit_transaction(struct btrfs_trans_handle *trans,

CRA Git | Maintained and supported by SUSTech CRA and CCSE