Commit cf9d0140 authored Aug 15, 2017 by John Fastabend Committed by David S. Miller Aug 16, 2017

bpf: devmap: remove unnecessary value size check



In the devmap alloc map logic we check to ensure that the sizeof the
values are not greater than KMALLOC_MAX_SIZE. But, in the dev map case
we ensure the value size is 4bytes earlier in the function because all
values should be netdev ifindex values.

The second check is harmless but is not needed so remove it.

Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ef70f9a2

kernel/bpf/devmap.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -83,12 +83,6 @@ static struct bpf_map dev_map_alloc(union bpf_attr attr)
		attr->value_size != 4 \|\| attr->map_flags)
		return ERR_PTR(-EINVAL);

		/* if value_size is bigger, the user space won't be able to
		* access the elements.
		*/
		if (attr->value_size > KMALLOC_MAX_SIZE)
		return ERR_PTR(-E2BIG);

		dtab = kzalloc(sizeof(*dtab), GFP_USER);
		if (!dtab)
		return ERR_PTR(-ENOMEM);

Admin message