Commit cf90c06f authored Mar 10, 2019 by David Emett Committed by Greg Kroah-Hartman Mar 28, 2019

tty: fix read of tty->pgrp outside of ctrl_lock



The intention was clearly to use the tty_pgrp local variable rather than
re-read tty->pgrp outside of ctrl_lock, so do that.

This bug was introduced by commit 2812d9e9 ("tty: Combine
SIGTTOU/SIGTTIN handling").

Signed-off-by: David Emett <dave@sp4m.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3adf2aa8

drivers/tty/tty_jobctrl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -44,7 +44,7 @@ int __tty_check_change(struct tty_struct *tty, int sig)
		tty_pgrp = tty->pgrp;
		spin_unlock_irqrestore(&tty->ctrl_lock, flags);

		if (tty_pgrp && pgrp != tty->pgrp) {
		if (tty_pgrp && pgrp != tty_pgrp) {
		if (is_ignored(sig)) {
		if (sig == SIGTTIN)
		ret = -EIO;

Admin message