Commit cf834027 authored Jul 20, 2018 by Trond Myklebust

NFS: Fix excessive attribute revalidation in nfs_execute_ok()

When nfs_update_inode() sets NFS_INO_INVALID_ACCESS it is a sign that
we want to revalidate the access cache, not the inode attributes.
In fact we only want to revalidate here if we see that the mode bits
are invalid, so check for NFS_INO_INVALID_OTHER instead.

Reported-by: Olga Kornievskaia <aglo@umich.edu>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent 7be7b3ca

fs/nfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2500,7 +2500,7 @@ static int nfs_execute_ok(struct inode *inode, int mask)
		struct nfs_server *server = NFS_SERVER(inode);
		int ret = 0;

		if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_ACCESS)) {
		if (nfs_check_cache_invalid(inode, NFS_INO_INVALID_OTHER)) {
		if (mask & MAY_NOT_BLOCK)
		return -ECHILD;
		ret = __nfs_revalidate_inode(server, inode);

Admin message