Commit cf56e3b9 authored Aug 16, 2017 by John Fastabend Committed by David S. Miller Aug 16, 2017

bpf: sockmap state change warning fix



psock will uninitialized in default case we need to do the same psock lookup
and check as in other branch. Fixes compile warning below.

kernel/bpf/sockmap.c: In function ‘smap_state_change’:
kernel/bpf/sockmap.c:156:21: warning: ‘psock’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  struct smap_psock *psock;

Fixes: 174a79ff ("bpf: sockmap with sk redirect support")
Reported-by: David Miller <davem@davemloft.net>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d978db8d

kernel/bpf/sockmap.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -188,6 +188,9 @@ static void smap_state_change(struct sock *sk)
		smap_release_sock(sk);
		break;
		default:
		psock = smap_psock_sk(sk);
		if (unlikely(!psock))
		break;
		smap_report_sk_error(psock, EPIPE);
		break;
		}

Admin message