Commit cf4e594e authored by Jouni Malinen's avatar Jouni Malinen Committed by John W. Linville
Browse files

nl80211: Add notification for dropped Deauth/Disassoc 



Add a new notification to indicate that a received, unprotected
Deauthentication or Disassociation frame was dropped due to
management frame protection being in use. This notification is
needed to allow user space (e.g., wpa_supplicant) to implement
SA Query procedure to recover from association state mismatch
between an AP and STA.

This is needed to avoid getting stuck in non-working state when MFP
(IEEE 802.11w) is used and a protected Deauthentication or
Disassociation frame is dropped for any reason. After that, the
station would silently discard any unprotected Deauthentication or
Disassociation frame that could be indicating that the AP does not
have association for the STA (when the Reason Code would be 6 or 7).
IEEE Std 802.11w-2009, 11.13 describes this recovery mechanism.

Signed-off-by: default avatarJouni Malinen <j@w1.fi>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 5928b91a

include/linux/nl80211.h

+10 −0
Original line number Diff line number Diff line
@@ -399,6 +399,13 @@ 
 * @NL80211_CMD_LEAVE_MESH: Leave the mesh network -- no special arguments, the

 *	network is determined by the network interface.

 *

 * @NL80211_CMD_UNPROT_DEAUTHENTICATE: Unprotected deauthentication frame

 *	notification. This event is used to indicate that an unprotected

 *	deauthentication frame was dropped when MFP is in use.

 * @NL80211_CMD_UNPROT_DISASSOCIATE: Unprotected disassociation frame

 *	notification. This event is used to indicate that an unprotected

 *	disassociation frame was dropped when MFP is in use.

 *

 * @NL80211_CMD_MAX: highest used command number

 * @__NL80211_CMD_AFTER_LAST: internal use

 */
@@ -508,6 +515,9 @@ enum nl80211_commands { 
	NL80211_CMD_JOIN_MESH,

	NL80211_CMD_LEAVE_MESH,



	NL80211_CMD_UNPROT_DEAUTHENTICATE,

	NL80211_CMD_UNPROT_DISASSOCIATE,



	/* add new commands above here */



	/* used to define NL80211_CMD_MAX below */

include/net/cfg80211.h

+26 −0
Original line number Diff line number Diff line
@@ -2359,6 +2359,32 @@ void cfg80211_send_disassoc(struct net_device *dev, const u8 *buf, size_t len); 
void __cfg80211_send_disassoc(struct net_device *dev, const u8 *buf,

	size_t len);



/**

 * cfg80211_send_unprot_deauth - notification of unprotected deauthentication

 * @dev: network device

 * @buf: deauthentication frame (header + body)

 * @len: length of the frame data

 *

 * This function is called whenever a received Deauthentication frame has been

 * dropped in station mode because of MFP being used but the Deauthentication

 * frame was not protected. This function may sleep.

 */

void cfg80211_send_unprot_deauth(struct net_device *dev, const u8 *buf,

				 size_t len);



/**

 * cfg80211_send_unprot_disassoc - notification of unprotected disassociation

 * @dev: network device

 * @buf: disassociation frame (header + body)

 * @len: length of the frame data

 *

 * This function is called whenever a received Disassociation frame has been

 * dropped in station mode because of MFP being used but the Disassociation

 * frame was not protected. This function may sleep.

 */

void cfg80211_send_unprot_disassoc(struct net_device *dev, const u8 *buf,

				   size_t len);



/**

 * cfg80211_michael_mic_failure - notification of Michael MIC failure (TKIP)

 * @dev: network device

net/mac80211/rx.c

+20 −2
Original line number Diff line number Diff line
@@ -1540,12 +1540,30 @@ ieee80211_drop_unencrypted_mgmt(struct ieee80211_rx_data *rx) 
	if (rx->sta && test_sta_flags(rx->sta, WLAN_STA_MFP)) {

		if (unlikely(!ieee80211_has_protected(fc) &&

			     ieee80211_is_unicast_robust_mgmt_frame(rx->skb) &&

			     rx->key))

			     rx->key)) {

			if (ieee80211_is_deauth(fc))

				cfg80211_send_unprot_deauth(rx->sdata->dev,

							    rx->skb->data,

							    rx->skb->len);

			else if (ieee80211_is_disassoc(fc))

				cfg80211_send_unprot_disassoc(rx->sdata->dev,

							      rx->skb->data,

							      rx->skb->len);

			return -EACCES;

		}

		/* BIP does not use Protected field, so need to check MMIE */

		if (unlikely(ieee80211_is_multicast_robust_mgmt_frame(rx->skb) &&

			     ieee80211_get_mmie_keyidx(rx->skb) < 0))

			     ieee80211_get_mmie_keyidx(rx->skb) < 0)) {

			if (ieee80211_is_deauth(fc))

				cfg80211_send_unprot_deauth(rx->sdata->dev,

							    rx->skb->data,

							    rx->skb->len);

			else if (ieee80211_is_disassoc(fc))

				cfg80211_send_unprot_disassoc(rx->sdata->dev,

							      rx->skb->data,

							      rx->skb->len);

			return -EACCES;

		}

		/*

		 * When using MFP, Action frames are not allowed prior to

		 * having configured keys.

net/wireless/mlme.c

+22 −0
Original line number Diff line number Diff line
@@ -263,6 +263,28 @@ void cfg80211_send_disassoc(struct net_device *dev, const u8 *buf, size_t len) 
}

EXPORT_SYMBOL(cfg80211_send_disassoc);



void cfg80211_send_unprot_deauth(struct net_device *dev, const u8 *buf,

				 size_t len)

{

	struct wireless_dev *wdev = dev->ieee80211_ptr;

	struct wiphy *wiphy = wdev->wiphy;

	struct cfg80211_registered_device *rdev = wiphy_to_dev(wiphy);



	nl80211_send_unprot_deauth(rdev, dev, buf, len, GFP_ATOMIC);

}

EXPORT_SYMBOL(cfg80211_send_unprot_deauth);



void cfg80211_send_unprot_disassoc(struct net_device *dev, const u8 *buf,

				   size_t len)

{

	struct wireless_dev *wdev = dev->ieee80211_ptr;

	struct wiphy *wiphy = wdev->wiphy;

	struct cfg80211_registered_device *rdev = wiphy_to_dev(wiphy);



	nl80211_send_unprot_disassoc(rdev, dev, buf, len, GFP_ATOMIC);

}

EXPORT_SYMBOL(cfg80211_send_unprot_disassoc);



static void __cfg80211_auth_remove(struct wireless_dev *wdev, const u8 *addr)

{

	int i;

net/wireless/nl80211.c

+16 −0
Original line number Diff line number Diff line
@@ -5473,6 +5473,22 @@ void nl80211_send_disassoc(struct cfg80211_registered_device *rdev, 
				NL80211_CMD_DISASSOCIATE, gfp);

}



void nl80211_send_unprot_deauth(struct cfg80211_registered_device *rdev,

				struct net_device *netdev, const u8 *buf,

				size_t len, gfp_t gfp)

{

	nl80211_send_mlme_event(rdev, netdev, buf, len,

				NL80211_CMD_UNPROT_DEAUTHENTICATE, gfp);

}



void nl80211_send_unprot_disassoc(struct cfg80211_registered_device *rdev,

				  struct net_device *netdev, const u8 *buf,

				  size_t len, gfp_t gfp)

{

	nl80211_send_mlme_event(rdev, netdev, buf, len,

				NL80211_CMD_UNPROT_DISASSOCIATE, gfp);

}



static void nl80211_send_mlme_timeout(struct cfg80211_registered_device *rdev,

				      struct net_device *netdev, int cmd,

				      const u8 *addr, gfp_t gfp)

CRA Git | Maintained and supported by SUSTech CRA and CCSE