Commit cf4e55e7 authored Feb 10, 2017 by Shivasharan S Committed by Martin K. Petersen Feb 13, 2017

scsi: megaraid_sas: max_fw_cmds are decremented twice, remove duplicate



Fix to account for the reply_q_sz not exceeding the maximum commands
that the firmware can support, instance->max_fw_cmds is already
decremented in megasas_fusion_update_can_queue().  Remove the extra
decrement logic in code.

Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 013aec66

drivers/scsi/megaraid/megaraid_sas_fusion.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -1284,13 +1284,6 @@ megasas_init_adapter_fusion(struct megasas_instance *instance)

		megasas_fusion_update_can_queue(instance, PROBE_CONTEXT);

		/*
		* Reduce the max supported cmds by 1. This is to ensure that the
		* reply_q_sz (1 more than the max cmd that driver may send)
		* does not exceed max cmds that the FW can support
		*/
		instance->max_fw_cmds = instance->max_fw_cmds-1;

		/*
		* Only Driver's internal DCMDs and IOCTL DCMDs needs to have MFI frames
		*/

Admin message