Commit cf4a3ae4 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

fbdev: lock_fb_info cannot fail 



Ever since

commit c47747fd
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed May 11 14:58:34 2011 -0700

    fbmem: make read/write/ioctl use the frame buffer at open time

fbdev has gained proper refcounting for the fbinfo attached to any
open files, which means that the backing driver (stored in
fb_info->fbops) cannot untimely disappear anymore.

The only thing that can happen is that the entire device just outright
disappears and gets unregistered, but file_fb_info does check for
that. Except that it's racy - it only checks once at the start of a
file_ops, there's no guarantee that the underlying fbdev won't
untimely disappear. Aside: A proper way to fix that race is probably
to replicate the srcu trickery we've rolled out in drm.

But given that this race has existed since forever it's probably not
one we need to fix right away. do_unregister_framebuffer also nowhere
clears fb_info->fbops, hence the check in lock_fb_info can't possible
catch a disappearing fbdev later on.

Long story short: Ever since the above commit the fb_info->fbops
checks have essentially become dead code. Remove this all.

Aside from the file_ops callbacks, and stuff called from there
there's only register/unregister code left. If that goes wrong a driver
managed to register/unregister a device instance twice or in the wrong
order.  That's just a driver bug.

v2:
- fb_mmap had an open-coded version of the fbinfo->fops check, because
  it doesn't need the fbinfo->lock. Delete that too.
- Use the wrapper function in fb_open/release now, since no difference
  anymore.

Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Yisheng Xie <ysxie@foxmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: "Noralf Trønnes" <noralf@tronnes.org>
Cc: Peter Rosin <peda@axentia.se>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Mikulas Patocka <mpatocka@redhat.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-fbdev@vger.kernel.org
Link: https://patchwork.freedesktop.org/patch/msgid/20190528090304.9388-17-daniel.vetter@ffwll.ch
parent cd90b5fd

drivers/video/fbdev/core/fbcmap.c

+1 −5
Original line number Diff line number Diff line
@@ -285,11 +285,7 @@ int fb_set_user_cmap(struct fb_cmap_user *cmap, struct fb_info *info) 
		goto out;

	}

	umap.start = cmap->start;

	if (!lock_fb_info(info)) {

		rc = -ENODEV;

		goto out;

	}



	lock_fb_info(info);

	rc = fb_set_cmap(&umap, info);

	unlock_fb_info(info);

out:

drivers/video/fbdev/core/fbcon.c

+1 −2
Original line number Diff line number Diff line
@@ -2364,8 +2364,7 @@ static void fbcon_generic_blank(struct vc_data *vc, struct fb_info *info, 
	}





	if (!lock_fb_info(info))

		return;

	lock_fb_info(info);

	event.info = info;

	event.data = &blank;

	fb_notifier_call_chain(FB_EVENT_CONBLANK, &event);

drivers/video/fbdev/core/fbmem.c

+17 −56
Original line number Diff line number Diff line
@@ -80,17 +80,6 @@ static void put_fb_info(struct fb_info *fb_info) 
		fb_info->fbops->fb_destroy(fb_info);

}



int lock_fb_info(struct fb_info *info)

{

	mutex_lock(&info->lock);

	if (!info->fbops) {

		mutex_unlock(&info->lock);

		return 0;

	}

	return 1;

}

EXPORT_SYMBOL(lock_fb_info);



/*

 * Helpers

 */
@@ -1121,8 +1110,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 


	switch (cmd) {

	case FBIOGET_VSCREENINFO:

		if (!lock_fb_info(info))

			return -ENODEV;

		lock_fb_info(info);

		var = info->var;

		unlock_fb_info(info);
@@ -1132,10 +1120,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
		if (copy_from_user(&var, argp, sizeof(var)))

			return -EFAULT;

		console_lock();

		if (!lock_fb_info(info)) {

			console_unlock();

			return -ENODEV;

		}

		lock_fb_info(info);

		info->flags |= FBINFO_MISC_USEREVENT;

		ret = fb_set_var(info, &var);

		info->flags &= ~FBINFO_MISC_USEREVENT;
@@ -1145,8 +1130,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
			ret = -EFAULT;

		break;

	case FBIOGET_FSCREENINFO:

		if (!lock_fb_info(info))

			return -ENODEV;

		lock_fb_info(info);

		fix = info->fix;

		if (info->flags & FBINFO_HIDE_SMEM_START)

			fix.smem_start = 0;
@@ -1162,8 +1146,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
	case FBIOGETCMAP:

		if (copy_from_user(&cmap, argp, sizeof(cmap)))

			return -EFAULT;

		if (!lock_fb_info(info))

			return -ENODEV;

		lock_fb_info(info);

		cmap_from = info->cmap;

		unlock_fb_info(info);

		ret = fb_cmap_to_user(&cmap_from, &cmap);
@@ -1172,10 +1155,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
		if (copy_from_user(&var, argp, sizeof(var)))

			return -EFAULT;

		console_lock();

		if (!lock_fb_info(info)) {

			console_unlock();

			return -ENODEV;

		}

		lock_fb_info(info);

		ret = fb_pan_display(info, &var);

		unlock_fb_info(info);

		console_unlock();
@@ -1192,8 +1172,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
			return -EINVAL;

		con2fb.framebuffer = -1;

		event.data = &con2fb;

		if (!lock_fb_info(info))

			return -ENODEV;

		lock_fb_info(info);

		event.info = info;

		fb_notifier_call_chain(FB_EVENT_GET_CONSOLE_MAP, &event);

		unlock_fb_info(info);
@@ -1214,10 +1193,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
		}

		event.data = &con2fb;

		console_lock();

		if (!lock_fb_info(info)) {

			console_unlock();

			return -ENODEV;

		}

		lock_fb_info(info);

		event.info = info;

		ret = fb_notifier_call_chain(FB_EVENT_SET_CONSOLE_MAP, &event);

		unlock_fb_info(info);
@@ -1225,10 +1201,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
		break;

	case FBIOBLANK:

		console_lock();

		if (!lock_fb_info(info)) {

			console_unlock();

			return -ENODEV;

		}

		lock_fb_info(info);

		info->flags |= FBINFO_MISC_USEREVENT;

		ret = fb_blank(info, arg);

		info->flags &= ~FBINFO_MISC_USEREVENT;
@@ -1236,8 +1209,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd, 
		console_unlock();

		break;

	default:

		if (!lock_fb_info(info))

			return -ENODEV;

		lock_fb_info(info);

		fb = info->fbops;

		if (fb->fb_ioctl)

			ret = fb->fb_ioctl(info, cmd, arg);
@@ -1357,8 +1329,7 @@ static int fb_get_fscreeninfo(struct fb_info *info, unsigned int cmd, 
{

	struct fb_fix_screeninfo fix;



	if (!lock_fb_info(info))

		return -ENODEV;

	lock_fb_info(info);

	fix = info->fix;

	if (info->flags & FBINFO_HIDE_SMEM_START)

		fix.smem_start = 0;
@@ -1418,8 +1389,6 @@ fb_mmap(struct file *file, struct vm_area_struct * vma) 
	if (!info)

		return -ENODEV;

	fb = info->fbops;

	if (!fb)

		return -ENODEV;

	mutex_lock(&info->mm_lock);

	if (fb->fb_mmap) {

		int res;
@@ -1483,7 +1452,7 @@ __releases(&info->lock) 
	if (IS_ERR(info))

		return PTR_ERR(info);



	mutex_lock(&info->lock);

	lock_fb_info(info);

	if (!try_module_get(info->fbops->owner)) {

		res = -ENODEV;

		goto out;
@@ -1499,7 +1468,7 @@ __releases(&info->lock) 
		fb_deferred_io_open(info, inode, file);

#endif

out:

	mutex_unlock(&info->lock);

	unlock_fb_info(info);

	if (res)

		put_fb_info(info);

	return res;
@@ -1512,11 +1481,11 @@ __releases(&info->lock) 
{

	struct fb_info * const info = file->private_data;



	mutex_lock(&info->lock);

	lock_fb_info(info);

	if (info->fbops->fb_release)

		info->fbops->fb_release(info,1);

	module_put(info->fbops->owner);

	mutex_unlock(&info->lock);

	unlock_fb_info(info);

	put_fb_info(info);

	return 0;

}
@@ -1734,14 +1703,10 @@ static int do_register_framebuffer(struct fb_info *fb_info) 
		console_lock();

	else

		atomic_inc(&ignore_console_lock_warning);

	if (!lock_fb_info(fb_info)) {

		ret = -ENODEV;

		goto unlock_console;

	}



	lock_fb_info(fb_info);

	ret = fbcon_fb_registered(fb_info);

	unlock_fb_info(fb_info);

unlock_console:



	if (!lockless_register_fb)

		console_unlock();

	else
@@ -1759,11 +1724,7 @@ static int unbind_console(struct fb_info *fb_info) 
		return -EINVAL;



	console_lock();

	if (!lock_fb_info(fb_info)) {

		console_unlock();

		return -ENODEV;

	}



	lock_fb_info(fb_info);

	event.info = fb_info;

	ret = fb_notifier_call_chain(FB_EVENT_FB_UNBIND, &event);

	unlock_fb_info(fb_info);

include/linux/fb.h

+4 −1
Original line number Diff line number Diff line
@@ -663,7 +663,10 @@ extern struct class *fb_class; 
	for (i = 0; i < FB_MAX; i++)		\

		if (!registered_fb[i]) {} else



extern int lock_fb_info(struct fb_info *info);

static inline void lock_fb_info(struct fb_info *info)

{

	mutex_lock(&info->lock);

}



static inline void unlock_fb_info(struct fb_info *info)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE