Commit cf3c0a15 authored Dec 17, 2014 by Linus Torvalds

x86: mm: fix VM_FAULT_RETRY handling



My commit 26178ec1 ("x86: mm: consolidate VM_FAULT_RETRY handling")
had a really stupid typo: the FAULT_FLAG_USER bit is in the 'flags'
variable, not the 'fault' variable. Duh,

The one silver lining in this is that Dave finding this at least
confirms that trinity actually triggers this special path easily, in a
way normal use does not.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent cc669743

arch/x86/mm/fault.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1247,7 +1247,7 @@ good_area:
		}

		/* User mode? Just return to handle the fatal exception */
		if (fault & FAULT_FLAG_USER)
		if (flags & FAULT_FLAG_USER)
		return;

		/* Not returning to user mode? Handle exceptions or die: */

Admin message