Commit cf067b5b authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Miquel Raynal
Browse files

mtd: rawnand: denali: remove unneeded casts in denali_{read, write}_pio 



Since (u32 *) can accept an opaque pointer, the explicit casting
from (void *) to (u32 *) is redundant. Change the function argument type
to remove the casts.

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 0e604fc9

drivers/mtd/nand/raw/denali.c

+5 −7
Original line number Diff line number Diff line
@@ -654,11 +654,10 @@ static void denali_setup_dma32(struct denali_nand_info *denali, 
	denali->host_write(denali, mode | 0x14000, 0x2400);

}



static int denali_pio_read(struct denali_nand_info *denali, void *buf,

static int denali_pio_read(struct denali_nand_info *denali, u32 *buf,

			   size_t size, int page)

{

	u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page;

	uint32_t *buf32 = (uint32_t *)buf;

	uint32_t irq_status, ecc_err_mask;

	int i;
@@ -670,7 +669,7 @@ static int denali_pio_read(struct denali_nand_info *denali, void *buf, 
	denali_reset_irq(denali);



	for (i = 0; i < size / 4; i++)

		*buf32++ = denali->host_read(denali, addr);

		buf[i] = denali->host_read(denali, addr);



	irq_status = denali_wait_for_irq(denali, INTR__PAGE_XFER_INC);

	if (!(irq_status & INTR__PAGE_XFER_INC))
@@ -682,18 +681,17 @@ static int denali_pio_read(struct denali_nand_info *denali, void *buf, 
	return irq_status & ecc_err_mask ? -EBADMSG : 0;

}



static int denali_pio_write(struct denali_nand_info *denali,

			    const void *buf, size_t size, int page)

static int denali_pio_write(struct denali_nand_info *denali, const u32 *buf,

			    size_t size, int page)

{

	u32 addr = DENALI_MAP01 | DENALI_BANK(denali) | page;

	const uint32_t *buf32 = (uint32_t *)buf;

	uint32_t irq_status;

	int i;



	denali_reset_irq(denali);



	for (i = 0; i < size / 4; i++)

		denali->host_write(denali, addr, *buf32++);

		denali->host_write(denali, addr, buf[i]);



	irq_status = denali_wait_for_irq(denali,

				INTR__PROGRAM_COMP | INTR__PROGRAM_FAIL);

CRA Git | Maintained and supported by SUSTech CRA and CCSE