Commit cf01514c authored Jan 23, 2020 by Oded Gabbay

habanalabs: patched cb equals user cb in device memset



During device memory memset, the driver allocates and use a CB (command
buffer). To reuse existing code, it keeps a pointer to the CB in two
variables, user_cb and patched_cb. Therefore, there is no need to "put"
both the user_cb and patched_cb, as it will cause an underflow of the
refcnt of the CB.

Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

parent a37e4719

drivers/misc/habanalabs/goya/goya.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -4690,8 +4690,6 @@ static int goya_memset_device_memory(struct hl_device *hdev, u64 addr, u64 size,

		rc = goya_send_job_on_qman0(hdev, job);

		hl_cb_put(job->patched_cb);

		hl_debugfs_remove_job(hdev, job);
		kfree(job);
		cb->cs_cnt--;

Admin message