media: cxusb: pass buf as a const u8 * pointer and make buf static const (cee32edb) · Commits · 戴 / test

Don't populate the read-only u8 array buf on the stack at run time but instead make it static const; makes object code smaller saving over 480 bytes: Before: text data bss dec hex filename 33030 65936 192 99158 18356 drivers/media/usb/dvb-usb/cxusb.o After: text data bss dec hex filename 32446 66032 192 98670 1816e drivers/media/usb/dvb-usb/cxusb.o Signed-off-by:

Colin Ian King <colin.king@canonical.com> Signed-off-by:

Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:

Mauro Carvalho Chehab <mchehab@s-opensource.com>

drivers/media/usb/dvb-usb/cxusb.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -56,7 +56,7 @@ DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr);
		#define deb_i2c(args...) dprintk(dvb_usb_cxusb_debug, 0x02, args)

		static int cxusb_ctrl_msg(struct dvb_usb_device *d,
		u8 cmd, u8 wbuf, int wlen, u8 rbuf, int rlen)
		u8 cmd, const u8 wbuf, int wlen, u8 rbuf, int rlen)
		{
		struct cxusb_state *st = d->priv;
		int ret;
		@@ -290,7 +290,8 @@ static int cxusb_aver_power_ctrl(struct dvb_usb_device *d, int onoff)
		/* FIXME: We don't know why, but we need to configure the
		* lgdt3303 with the register settings below on resume */
		int i;
		u8 buf, bufs[] = {
		u8 buf;
		static const u8 bufs[] = {
		0x0e, 0x2, 0x00, 0x7f,
		0x0e, 0x2, 0x02, 0xfe,
		0x0e, 0x2, 0x02, 0x01,

Admin message