Commit ced117c7 authored by Dmitri Vorobiev's avatar Dmitri Vorobiev Committed by Al Viro
Browse files

Remove two unneeded exports and make two symbols static in fs/mpage.c 



Commit 29a814d2 (vfs: add hooks for
ext4's delayed allocation support) exported the following functions

mpage_bio_submit()
__mpage_writepage()

for the benefit of ext4's delayed allocation support. Since commit
a1d6cc56 (ext4: Rework the
ext4_da_writepages() function), these functions are not used by the
ext4 driver anymore. However, the now unnecessary exports still
remain, and this patch removes those. Moreover, these two functions
can become static again.

The issue was spotted by namespacecheck.

Signed-off-by: default avatarDmitri Vorobiev <dmitri.vorobiev@movial.com>
Reviewed-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 47e4491b

fs/mpage.c

+9 −4
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ static void mpage_end_io_write(struct bio *bio, int err) 
	bio_put(bio);

}



struct bio *mpage_bio_submit(int rw, struct bio *bio)

static struct bio *mpage_bio_submit(int rw, struct bio *bio)

{

	bio->bi_end_io = mpage_end_io_read;

	if (rw == WRITE)
@@ -90,7 +90,6 @@ struct bio *mpage_bio_submit(int rw, struct bio *bio) 
	submit_bio(rw, bio);

	return NULL;

}

EXPORT_SYMBOL(mpage_bio_submit);



static struct bio *

mpage_alloc(struct block_device *bdev,
@@ -439,7 +438,14 @@ EXPORT_SYMBOL(mpage_readpage); 
 * just allocate full-size (16-page) BIOs.

 */



int __mpage_writepage(struct page *page, struct writeback_control *wbc,

struct mpage_data {

	struct bio *bio;

	sector_t last_block_in_bio;

	get_block_t *get_block;

	unsigned use_writepage;

};



static int __mpage_writepage(struct page *page, struct writeback_control *wbc,

		      void *data)

{

	struct mpage_data *mpd = data;
@@ -648,7 +654,6 @@ out: 
	mpd->bio = bio;

	return ret;

}

EXPORT_SYMBOL(__mpage_writepage);



/**

 * mpage_writepages - walk the list of dirty pages of the given address space & writepage() all of them

include/linux/mpage.h

+0 −10
Original line number Diff line number Diff line
@@ -11,21 +11,11 @@ 
 */

#ifdef CONFIG_BLOCK



struct mpage_data {

	struct bio *bio;

	sector_t last_block_in_bio;

	get_block_t *get_block;

	unsigned use_writepage;

};



struct writeback_control;



struct bio *mpage_bio_submit(int rw, struct bio *bio);

int mpage_readpages(struct address_space *mapping, struct list_head *pages,

				unsigned nr_pages, get_block_t get_block);

int mpage_readpage(struct page *page, get_block_t get_block);

int __mpage_writepage(struct page *page, struct writeback_control *wbc,

		      void *data);

int mpage_writepages(struct address_space *mapping,

		struct writeback_control *wbc, get_block_t get_block);

int mpage_writepage(struct page *page, get_block_t *get_block,

CRA Git | Maintained and supported by SUSTech CRA and CCSE