Commit cebf4cfd authored Oct 10, 2013 by Johan Hedberg Committed by Marcel Holtmann Oct 10, 2013

Bluetooth: Fix checking for HCI_SETUP flag when receiving mgmt commands



When the HCI_SETUP flag is set the controller has not yet been announced
over mgmt and therefore doesn't exist from that perspective. If we
nevertheless get a mgmt command for it we should respond with the
appropriate INVALID_INDEX error.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent c4e5bafa

net/bluetooth/mgmt.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3753,7 +3753,8 @@ int mgmt_control(struct sock sk, struct msghdr msg, size_t msglen)
		goto done;
		}

		if (test_bit(HCI_USER_CHANNEL, &hdev->dev_flags)) {
		if (test_bit(HCI_SETUP, &hdev->dev_flags) \|\|
		test_bit(HCI_USER_CHANNEL, &hdev->dev_flags)) {
		err = cmd_status(sk, index, opcode,
		MGMT_STATUS_INVALID_INDEX);
		goto done;

Admin message