Commit ce7a3fdc authored Jun 15, 2006 by Russell King Committed by Russell King Jun 18, 2006

[ARM] Remove rt_sigframe puc and pinfo pointers



These two members appear to be surplus to requirements.  Discussing
this issue with glibc folk:

| > Additionally, do you see any need for these weird "puc" and "pinfo"
| > pointers in the kernels rt_sigframe structure?  Can we kill them?
|
| We can kill them.  I checked with Phil B. about them last week, and he
| didn't remember any reason they still needed to be there.  And nothing
| should know where they are on the stack.  Unfortunately, doing this
| will upset GDB, which knows that the saved registers are 0x88 bytes
| above the stack pointer on entrance to an rt signal trampoline; but,
| since puc and pinfo are quite recognizable, I can adapt GDB to support
| the new layout if you want to remove them.

So remove them.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent 427abfa2

arch/arm/kernel/signal.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -200,8 +200,6 @@ struct sigframe {
		};

		struct rt_sigframe {
		struct siginfo __user *pinfo;
		void __user *puc;
		struct siginfo info;
		struct ucontext uc;
		unsigned long retcode[2];
		@@ -511,8 +509,6 @@ setup_rt_frame(int usig, struct k_sigaction ka, siginfo_t info,
		if (!frame)
		return 1;

		__put_user_error(&frame->info, &frame->pinfo, err);
		__put_user_error(&frame->uc, &frame->puc, err);
		err \|= copy_siginfo_to_user(&frame->info, info);

		__put_user_error(0, &frame->uc.uc_flags, err);

Admin message