Commit ce7a058a authored by Yunhong Jiang's avatar Yunhong Jiang Committed by Paolo Bonzini
Browse files

KVM: x86: support using the vmx preemption timer for tsc deadline timer 



The VMX preemption timer can be used to virtualize the TSC deadline timer.
The VMX preemption timer is armed when the vCPU is running, and a VMExit
will happen if the virtual TSC deadline timer expires.

When the vCPU thread is blocked because of HLT, KVM will switch to use
an hrtimer, and then go back to the VMX preemption timer when the vCPU
thread is unblocked.

This solution avoids the complex OS's hrtimer system, and the host
timer interrupt handling cost, replacing them with a little math
(for guest->host TSC and host TSC->preemption timer conversion)
and a cheaper VMexit.  This benefits latency for isolated pCPUs.

[A word about performance... Yunhong reported a 30% reduction in average
 latency from cyclictest.  I made a similar test with tscdeadline_latency
 from kvm-unit-tests, and measured

 - ~20 clock cycles loss (out of ~3200, so less than 1% but still
   statistically significant) in the worst case where the test halts
   just after programming the TSC deadline timer

 - ~800 clock cycles gain (25% reduction in latency) in the best case
   where the test busy waits.

 I removed the VMX bits from Yunhong's patch, to concentrate them in the
 next patch - Paolo]

Signed-off-by: default avatarYunhong Jiang <yunhong.jiang@intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 53f9eedf

arch/x86/include/asm/kvm_host.h

+3 −0
Original line number Diff line number Diff line
@@ -1005,6 +1005,9 @@ struct kvm_x86_ops { 
	int (*update_pi_irte)(struct kvm *kvm, unsigned int host_irq,

			      uint32_t guest_irq, bool set);

	void (*apicv_post_state_restore)(struct kvm_vcpu *vcpu);



	int (*set_hv_timer)(struct kvm_vcpu *vcpu, u64 guest_deadline_tsc);

	void (*cancel_hv_timer)(struct kvm_vcpu *vcpu);

};



struct kvm_arch_async_pf {

arch/x86/kvm/lapic.c

+72 −1
Original line number Diff line number Diff line
@@ -1343,6 +1343,68 @@ static void start_sw_tscdeadline(struct kvm_lapic *apic) 
	local_irq_restore(flags);

}



bool kvm_lapic_hv_timer_in_use(struct kvm_vcpu *vcpu)

{

	return vcpu->arch.apic->lapic_timer.hv_timer_in_use;

}

EXPORT_SYMBOL_GPL(kvm_lapic_hv_timer_in_use);



void kvm_lapic_expired_hv_timer(struct kvm_vcpu *vcpu)

{

	struct kvm_lapic *apic = vcpu->arch.apic;



	WARN_ON(!apic->lapic_timer.hv_timer_in_use);

	WARN_ON(swait_active(&vcpu->wq));

	kvm_x86_ops->cancel_hv_timer(vcpu);

	apic->lapic_timer.hv_timer_in_use = false;

	apic_timer_expired(apic);

}

EXPORT_SYMBOL_GPL(kvm_lapic_expired_hv_timer);



void kvm_lapic_switch_to_hv_timer(struct kvm_vcpu *vcpu)

{

	struct kvm_lapic *apic = vcpu->arch.apic;



	WARN_ON(apic->lapic_timer.hv_timer_in_use);



	if (apic_lvtt_tscdeadline(apic) &&

	    !atomic_read(&apic->lapic_timer.pending)) {

		u64 tscdeadline = apic->lapic_timer.tscdeadline;



		if (!kvm_x86_ops->set_hv_timer(vcpu, tscdeadline)) {

			apic->lapic_timer.hv_timer_in_use = true;

			hrtimer_cancel(&apic->lapic_timer.timer);



			/* In case the sw timer triggered in the window */

			if (atomic_read(&apic->lapic_timer.pending)) {

				apic->lapic_timer.hv_timer_in_use = false;

				kvm_x86_ops->cancel_hv_timer(apic->vcpu);

			}

		}

		trace_kvm_hv_timer_state(vcpu->vcpu_id,

				apic->lapic_timer.hv_timer_in_use);

	}

}

EXPORT_SYMBOL_GPL(kvm_lapic_switch_to_hv_timer);



void kvm_lapic_switch_to_sw_timer(struct kvm_vcpu *vcpu)

{

	struct kvm_lapic *apic = vcpu->arch.apic;



	/* Possibly the TSC deadline timer is not enabled yet */

	if (!apic->lapic_timer.hv_timer_in_use)

		return;



	kvm_x86_ops->cancel_hv_timer(vcpu);

	apic->lapic_timer.hv_timer_in_use = false;



	if (atomic_read(&apic->lapic_timer.pending))

		return;



	start_sw_tscdeadline(apic);

}

EXPORT_SYMBOL_GPL(kvm_lapic_switch_to_sw_timer);



static void start_apic_timer(struct kvm_lapic *apic)

{

	ktime_t now;
@@ -1389,6 +1451,15 @@ static void start_apic_timer(struct kvm_lapic *apic) 
			   ktime_to_ns(ktime_add_ns(now,

					apic->lapic_timer.period)));

	} else if (apic_lvtt_tscdeadline(apic)) {

		/* lapic timer in tsc deadline mode */

		u64 tscdeadline = apic->lapic_timer.tscdeadline;



		if (kvm_x86_ops->set_hv_timer &&

		    !kvm_x86_ops->set_hv_timer(apic->vcpu, tscdeadline)) {

			apic->lapic_timer.hv_timer_in_use = true;

			trace_kvm_hv_timer_state(apic->vcpu->vcpu_id,

					apic->lapic_timer.hv_timer_in_use);

		} else

			start_sw_tscdeadline(apic);

	}

}

arch/x86/kvm/lapic.h

+5 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ struct kvm_timer { 
	u64 tscdeadline;

	u64 expired_tscdeadline;

	atomic_t pending;			/* accumulated triggered timers */

	bool hv_timer_in_use;

};



struct kvm_lapic {
@@ -212,4 +213,8 @@ bool kvm_intr_is_single_vcpu_fast(struct kvm *kvm, struct kvm_lapic_irq *irq, 
			struct kvm_vcpu **dest_vcpu);

int kvm_vector_to_index(u32 vector, u32 dest_vcpus,

			const unsigned long *bitmap, u32 bitmap_size);

void kvm_lapic_switch_to_sw_timer(struct kvm_vcpu *vcpu);

void kvm_lapic_switch_to_hv_timer(struct kvm_vcpu *vcpu);

void kvm_lapic_expired_hv_timer(struct kvm_vcpu *vcpu);

bool kvm_lapic_hv_timer_in_use(struct kvm_vcpu *vcpu);

#endif

arch/x86/kvm/trace.h

+15 −0
Original line number Diff line number Diff line
@@ -1348,6 +1348,21 @@ TRACE_EVENT(kvm_avic_unaccelerated_access, 
		  __entry->vec)

);



TRACE_EVENT(kvm_hv_timer_state,

		TP_PROTO(unsigned int vcpu_id, unsigned int hv_timer_in_use),

		TP_ARGS(vcpu_id, hv_timer_in_use),

		TP_STRUCT__entry(

			__field(unsigned int, vcpu_id)

			__field(unsigned int, hv_timer_in_use)

			),

		TP_fast_assign(

			__entry->vcpu_id = vcpu_id;

			__entry->hv_timer_in_use = hv_timer_in_use;

			),

		TP_printk("vcpu_id %x hv_timer %x\n",

			__entry->vcpu_id,

			__entry->hv_timer_in_use)

);

#endif /* _TRACE_KVM_H */



#undef TRACE_INCLUDE_PATH

arch/x86/kvm/x86.c

+5 −0
Original line number Diff line number Diff line
@@ -2740,6 +2740,11 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cpu) 
				rdtsc() - vcpu->arch.last_host_tsc;

		if (tsc_delta < 0)

			mark_tsc_unstable("KVM discovered backwards TSC");



		if (kvm_lapic_hv_timer_in_use(vcpu) &&

				kvm_x86_ops->set_hv_timer(vcpu,

					kvm_get_lapic_tscdeadline_msr(vcpu)))

			kvm_lapic_switch_to_sw_timer(vcpu);

		if (check_tsc_unstable()) {

			u64 offset = kvm_compute_tsc_offset(vcpu,

						vcpu->arch.last_guest_tsc);

CRA Git | Maintained and supported by SUSTech CRA and CCSE