Commit ce7184bd authored Aug 24, 2012 by Alex Shi Committed by Konrad Rzeszutek Wilk Sep 05, 2012

xen: fix logical error in tlb flushing



While TLB_FLUSH_ALL gets passed as 'end' argument to
flush_tlb_others(), the Xen code was made to check its 'start'
parameter. That may give a incorrect op.cmd to MMUEXT_INVLPG_MULTI
instead of MMUEXT_TLB_FLUSH_MULTI. Then it causes some page can not
be flushed from TLB.

This patch fixed this issue.

Reported-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Alex Shi <alex.shi@intel.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Yongjie Ren <yongjie.ren@intel.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

parent 593d0a3e

arch/x86/xen/mmu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1283,7 +1283,7 @@ static void xen_flush_tlb_others(const struct cpumask *cpus,
		cpumask_clear_cpu(smp_processor_id(), to_cpumask(args->mask));

		args->op.cmd = MMUEXT_TLB_FLUSH_MULTI;
		if (start != TLB_FLUSH_ALL && (end - start) <= PAGE_SIZE) {
		if (end != TLB_FLUSH_ALL && (end - start) <= PAGE_SIZE) {
		args->op.cmd = MMUEXT_INVLPG_MULTI;
		args->op.arg1.linear_addr = start;
		}

Admin message