Commit ce698f4e authored Nov 11, 2020 by Andy Shevchenko

gpiolib: acpi: Move non-critical code outside of critical section



Mika noticed that some code is run under mutex when it doesn't require
the lock, like an error code assignment.

Move non-critical code outside of critical section.

Suggested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

parent 8dcb7a15

drivers/gpio/gpiolib-acpi.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1063,8 +1063,8 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,
		GPIO_ACTIVE_HIGH,
		flags);
		if (IS_ERR(desc)) {
		status = AE_ERROR;
		mutex_unlock(&achip->conn_lock);
		status = AE_ERROR;
		goto out;
		}

		@@ -1078,9 +1078,9 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,

		conn = kzalloc(sizeof(*conn), GFP_KERNEL);
		if (!conn) {
		status = AE_NO_MEMORY;
		gpiochip_free_own_desc(desc);
		mutex_unlock(&achip->conn_lock);
		status = AE_NO_MEMORY;
		goto out;
		}

Admin message