Commit ce679559 authored May 14, 2018 by Antoine Tenart Committed by Herbert Xu May 27, 2018

crypto: inside-secure - make the key and context size computation dynamic



This patches makes the key and context size computation dynamic when
using memzero_explicit() on these two arrays. This is safer, cleaner and
will help future modifications of the driver when these two parameters
sizes will changes (the context size will be bigger when using AEAD
algorithms).

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent fef0cfe5

drivers/crypto/inside-secure/safexcel_cipher.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -554,13 +554,13 @@ static int safexcel_cipher_cra_exit(struct crypto_tfm *tfm)
		{
		struct safexcel_cipher_ctx *ctx = crypto_tfm_ctx(tfm);

		memzero_explicit(ctx->key, 8 * sizeof(u32));
		memzero_explicit(ctx->key, sizeof(ctx->key));

		/* context not allocated, skip invalidation */
		if (!ctx->base.ctxr)
		return -ENOMEM;

		memzero_explicit(ctx->base.ctxr->data, 8 * sizeof(u32));
		memzero_explicit(ctx->base.ctxr->data, sizeof(ctx->base.ctxr->data));
		return 0;
		}

Admin message