Commit ce654b37 authored Feb 26, 2011 by Amir Goldstein Committed by Jan Kara Feb 28, 2011

ext3: skip orphan cleanup on rocompat fs



Orphan cleanup is currently executed even if the file system has some
number of unknown ROCOMPAT features, which deletes inodes and frees
blocks, which could be very bad for some RO_COMPAT features.

This patch skips the orphan cleanup if it contains readonly compatible
features not known by this ext3 implementation, which would prevent
the fs from being mounted (or remounted) readwrite.

Signed-off-by: Amir Goldstein <amir73il@users.sf.net>
Signed-off-by: Jan Kara <jack@suse.cz>

parent 03885ac3

fs/ext3/super.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1464,6 +1464,13 @@ static void ext3_orphan_cleanup (struct super_block * sb,
		return;
		}

		/* Check if feature set allows readwrite operations */
		if (EXT3_HAS_RO_COMPAT_FEATURE(sb, ~EXT3_FEATURE_RO_COMPAT_SUPP)) {
		ext3_msg(sb, KERN_INFO, "Skipping orphan cleanup due to "
		"unknown ROCOMPAT features");
		return;
		}

		if (EXT3_SB(sb)->s_mount_state & EXT3_ERROR_FS) {
		if (es->s_last_orphan)
		jbd_debug(1, "Errors on filesystem, "

Admin message