Commit ce441011 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM / Suspend: Fix ordering of calls in suspend error paths 



The ACPI suspend code calls suspend_nvs_free() at a wrong place,
which may lead to a memory leak if there's an error executing
acpi_pm_prepare(), because acpi_pm_finish() will not be called in
that case.  However, the root cause of this problem is the
apparently confusing ordering of calls in suspend error paths that
needs to be fixed.

In addition to that, fix a typo in a label name in suspend.c.

Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Acked-by: default avatarLen Brown <len.brown@intel.com>
parent d074ee02

include/linux/suspend.h

+6 −4
Original line number Diff line number Diff line
@@ -61,14 +61,15 @@ typedef int __bitwise suspend_state_t; 
 *	before device drivers' late suspend callbacks are executed.  It returns

 *	0 on success or a negative error code otherwise, in which case the

 *	system cannot enter the desired sleep state (@prepare_late(), @enter(),

 *	@wake(), and @finish() will not be called in that case).

 *	and @wake() will not be called in that case).

 *

 * @prepare_late: Finish preparing the platform for entering the system sleep

 *	state indicated by @begin().

 *	@prepare_late is called before disabling nonboot CPUs and after

 *	device drivers' late suspend callbacks have been executed.  It returns

 *	0 on success or a negative error code otherwise, in which case the

 *	system cannot enter the desired sleep state (@enter() and @wake()).

 *	system cannot enter the desired sleep state (@enter() will not be

 *	executed).

 *

 * @enter: Enter the system sleep state indicated by @begin() or represented by

 *	the argument if @begin() is not implemented.
@@ -81,14 +82,15 @@ typedef int __bitwise suspend_state_t; 
 *	resume callbacks are executed.

 *	This callback is optional, but should be implemented by the platforms

 *	that implement @prepare_late().  If implemented, it is always called

 *	after @enter(), even if @enter() fails.

 *	after @prepare_late and @enter(), even if one of them fails.

 *

 * @finish: Finish wake-up of the platform.

 *	@finish is called right prior to calling device drivers' regular suspend

 *	callbacks.

 *	This callback is optional, but should be implemented by the platforms

 *	that implement @prepare().  If implemented, it is always called after

 *	@enter() and @wake(), if implemented, even if any of them fails.

 *	@enter() and @wake(), even if any of them fails.  It is executed after

 *	a failing @prepare.

 *

 * @end: Called by the PM core right after resuming devices, to indicate to

 *	the platform that the system has returned to the working state or

kernel/power/suspend.c

+4 −5
Original line number Diff line number Diff line
@@ -136,19 +136,19 @@ static int suspend_enter(suspend_state_t state) 
	if (suspend_ops->prepare) {

		error = suspend_ops->prepare();

		if (error)

			return error;

			goto Platform_finish;

	}



	error = dpm_suspend_noirq(PMSG_SUSPEND);

	if (error) {

		printk(KERN_ERR "PM: Some devices failed to power down\n");

		goto Platfrom_finish;

		goto Platform_finish;

	}



	if (suspend_ops->prepare_late) {

		error = suspend_ops->prepare_late();

		if (error)

			goto Power_up_devices;

			goto Platform_wake;

	}



	if (suspend_test(TEST_PLATFORM))
@@ -180,10 +180,9 @@ static int suspend_enter(suspend_state_t state) 
	if (suspend_ops->wake)

		suspend_ops->wake();



 Power_up_devices:

	dpm_resume_noirq(PMSG_RESUME);



 Platfrom_finish:

 Platform_finish:

	if (suspend_ops->finish)

		suspend_ops->finish();

CRA Git | Maintained and supported by SUSTech CRA and CCSE