Commit ce42c176 authored Sep 11, 2018 by Nathan Chancellor Committed by Jens Axboe Sep 11, 2018

pata_atiixp: Remove unnecessary parentheses



Clang warns when more than one set of parentheses is used for a
single conditional statement:

drivers/ata/pata_atiixp.c:282:19: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
        if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
            ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ata/pata_atiixp.c:282:19: note: remove extraneous parentheses
around the comparison to silence this warning
        if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
           ~             ^                              ~
drivers/ata/pata_atiixp.c:282:19: note: use '=' to turn this equality
comparison into an assignment
        if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
                         ^~
                         =
1 warning generated.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 20bdc376

drivers/ata/pata_atiixp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -279,7 +279,7 @@ static int atiixp_init_one(struct pci_dev pdev, const struct pci_device_id id)
		const struct ata_port_info *ppi[] = { &info, &info };

		/* SB600 doesn't have secondary port wired */
		if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
		if (pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE)
		ppi[1] = &ata_dummy_port_info;

		return ata_pci_bmdma_init_one(pdev, ppi, &atiixp_sht, NULL,

Admin message