Commit ce312258 authored May 01, 2020 by Jeffrey Hugo Committed by Greg Kroah-Hartman May 05, 2020

bus: mhi: core: Make sure to powerdown if mhi_sync_power_up fails



Powerdown is necessary if mhi_sync_power_up fails due to a timeout, to
clean up the resources.  Otherwise a BUG could be triggered when
attempting to clean up MSIs because the IRQ is still active from a
request_irq().

Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20200430190555.32741-3-manivannan.sadhasivam@linaro.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 115f3251

drivers/bus/mhi/core/pm.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -902,7 +902,11 @@ int mhi_sync_power_up(struct mhi_controller *mhi_cntrl)
		MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state),
		msecs_to_jiffies(mhi_cntrl->timeout_ms));

		return (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -EIO;
		ret = (MHI_IN_MISSION_MODE(mhi_cntrl->ee)) ? 0 : -ETIMEDOUT;
		if (ret)
		mhi_power_down(mhi_cntrl, false);

		return ret;
		}
		EXPORT_SYMBOL(mhi_sync_power_up);

Admin message