Commit ce210e92 authored Apr 26, 2017 by Christoph Hellwig Committed by Jens Axboe Apr 26, 2017

ide-pm: always pass 0 error to __blk_end_request_all



ide_pm_execute_rq exectures a PM request synchronously, and in the failure
case where it calls __blk_end_request_all it never checks the error field
passed to the end_io callback, so don't bother setting it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent d188b90c

drivers/ide/ide-pm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -57,7 +57,7 @@ static int ide_pm_execute_rq(struct request *rq)
		if (unlikely(blk_queue_dying(q))) {
		rq->rq_flags \|= RQF_QUIET;
		scsi_req(rq)->result = -ENXIO;
		__blk_end_request_all(rq, scsi_req(rq)->result);
		__blk_end_request_all(rq, 0);
		spin_unlock_irq(q->queue_lock);
		return -ENXIO;
		}

Admin message