Commit ce1039bd authored by Steven Rostedt (Red Hat)'s avatar Steven Rostedt (Red Hat) Committed by Steven Rostedt
Browse files

tracing: Fix enabling of syscall events on the command line 

Commit 5f893b26 "tracing: Move enabling tracepoints to just after
rcu_init()" broke the enabling of system call events from the command
line. The reason was that the enabling of command line trace events
was moved before PID 1 started, and the syscall tracepoints require
that all tasks have the TIF_SYSCALL_TRACEPOINT flag set. But the
swapper task (pid 0) is not part of that. Since the swapper task is the
only task that is running at this early in boot, no task gets the
flag set, and the tracepoint never gets reached.

Instead of setting the swapper task flag (there should be no reason to
do that), re-enabled trace events again after the init thread (PID 1)
has been started. It requires disabling all command line events and
re-enabling them, as just enabling them again will not reset the logic
to set the TIF_SYSCALL_TRACEPOINT flag, as the syscall tracepoint will
be fooled into thinking that it was already set, and wont try setting
it again. For this reason, we must first disable it and re-enable it.

Link: http://lkml.kernel.org/r/1421188517-18312-1-git-send-email-mpe@ellerman.id.au
Link: http://lkml.kernel.org/r/20150115040506.216066449@goodmis.org



Reported-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 83829b74

kernel/trace/trace_events.c

+55 −14
Original line number Diff line number Diff line
@@ -2429,12 +2429,39 @@ static __init int event_trace_memsetup(void) 
	return 0;

}



static __init void

early_enable_events(struct trace_array *tr, bool disable_first)

{

	char *buf = bootup_event_buf;

	char *token;

	int ret;



	while (true) {

		token = strsep(&buf, ",");



		if (!token)

			break;

		if (!*token)

			continue;



		/* Restarting syscalls requires that we stop them first */

		if (disable_first)

			ftrace_set_clr_event(tr, token, 0);



		ret = ftrace_set_clr_event(tr, token, 1);

		if (ret)

			pr_warn("Failed to enable trace event: %s\n", token);



		/* Put back the comma to allow this to be called again */

		if (buf)

			*(buf - 1) = ',';

	}

}



static __init int event_trace_enable(void)

{

	struct trace_array *tr = top_trace_array();

	struct ftrace_event_call **iter, *call;

	char *buf = bootup_event_buf;

	char *token;

	int ret;



	if (!tr)
@@ -2456,18 +2483,7 @@ static __init int event_trace_enable(void) 
	 */

	__trace_early_add_events(tr);



	while (true) {

		token = strsep(&buf, ",");



		if (!token)

			break;

		if (!*token)

			continue;



		ret = ftrace_set_clr_event(tr, token, 1);

		if (ret)

			pr_warn("Failed to enable trace event: %s\n", token);

	}

	early_enable_events(tr, false);



	trace_printk_start_comm();
@@ -2478,6 +2494,31 @@ static __init int event_trace_enable(void) 
	return 0;

}



/*

 * event_trace_enable() is called from trace_event_init() first to

 * initialize events and perhaps start any events that are on the

 * command line. Unfortunately, there are some events that will not

 * start this early, like the system call tracepoints that need

 * to set the TIF_SYSCALL_TRACEPOINT flag of pid 1. But event_trace_enable()

 * is called before pid 1 starts, and this flag is never set, making

 * the syscall tracepoint never get reached, but the event is enabled

 * regardless (and not doing anything).

 */

static __init int event_trace_enable_again(void)

{

	struct trace_array *tr;



	tr = top_trace_array();

	if (!tr)

		return -ENODEV;



	early_enable_events(tr, true);



	return 0;

}



early_initcall(event_trace_enable_again);



static __init int event_trace_init(void)

{

	struct trace_array *tr;

CRA Git | Maintained and supported by SUSTech CRA and CCSE