Commit ce042c18 authored Jun 20, 2018 by Dan Carpenter Committed by Jens Axboe Jun 20, 2018

block: sed-opal: Fix a couple off by one bugs



resp->num is the number of tokens in resp->tok[].  It gets set in
response_parse().  So if n == resp->num then we're reading beyond the
end of the data.

Fixes: 455a7b23 ("block: Add Sed-opal library")
Reviewed-by: Scott Bauer <scott.bauer@intel.com>
Tested-by: Scott Bauer <scott.bauer@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent a1e79188

block/sed-opal.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -877,7 +877,7 @@ static size_t response_get_string(const struct parsed_resp *resp, int n,
		return 0;
		}

		if (n > resp->num) {
		if (n >= resp->num) {
		pr_debug("Response has %d tokens. Can't access %d\n",
		resp->num, n);
		return 0;
		@@ -916,7 +916,7 @@ static u64 response_get_u64(const struct parsed_resp *resp, int n)
		return 0;
		}

		if (n > resp->num) {
		if (n >= resp->num) {
		pr_debug("Response has %d tokens. Can't access %d\n",
		resp->num, n);
		return 0;

Admin message