Commit cdfb1a9f authored Jan 13, 2017 by Marcelo Ricardo Leitner Committed by David S. Miller Jan 16, 2017

sctp: remove useless code from sctp_apply_peer_addr_params



sctp_frag_point() doesn't store anything, and thus just calling it
cannot do anything useful.

sctp_apply_peer_addr_params is only called by
sctp_setsockopt_peer_addr_params. When operating on an asoc,
sctp_setsockopt_peer_addr_params will call sctp_apply_peer_addr_params
once for the asoc, and then once for each transport this asoc has,
meaning that the frag_point will be recomputed when updating the
transports and calling it when updating the asoc is not necessary.
IOW, no action is needed here and we can remove this call.

Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 11d05ac1

net/sctp/socket.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2430,7 +2430,6 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params,
		sctp_assoc_sync_pmtu(sctp_opt2sk(sp), asoc);
		} else if (asoc) {
		asoc->pathmtu = params->spp_pathmtu;
		sctp_frag_point(asoc, params->spp_pathmtu);
		} else {
		sp->pathmtu = params->spp_pathmtu;
		}

Admin message