hexdump: do not print debug dumps for !CONFIG_DEBUG (cdf17449) · Commits · 戴 / test

print_hex_dump_debug() is likely supposed to be analogous to pr_debug() or dev_dbg() & friends. Currently it will adhere to dynamic debug, but will not stub out prints if CONFIG_DEBUG is not set. Let's make it do the right thing, because I am tired of having my dmesg buffer full of hex dumps on production systems. Signed-off-by:

Linus Walleij <linus.walleij@linaro.org> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

include/linux/printk.h

+8 −2

Original line number	Diff line number	Diff line
		@@ -456,11 +456,17 @@ static inline void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
		groupsize, buf, len, ascii) \
		dynamic_hex_dump(prefix_str, prefix_type, rowsize, \
		groupsize, buf, len, ascii)
		#else
		#elif defined(DEBUG)
		#define print_hex_dump_debug(prefix_str, prefix_type, rowsize, \
		groupsize, buf, len, ascii) \
		print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, rowsize, \
		groupsize, buf, len, ascii)
		#endif /* defined(CONFIG_DYNAMIC_DEBUG) */
		#else
		static inline void print_hex_dump_debug(const char *prefix_str, int prefix_type,
		int rowsize, int groupsize,
		const void *buf, size_t len, bool ascii)
		{
		}
		#endif

		#endif

Admin message