Commit cded9369 authored Oct 28, 2014 by Vladimir Kondratiev Committed by John W. Linville Oct 30, 2014

wil6210: do not attempt FW recovery if interface is down

When interface is down, recovery flow should not be attempted.
Next ndo_open() will trigger target reset, that is FW recovery.

Doing recovery while interface is down cause internal "up", leaving
internal driver state in conflict with network stack. Then, when network
stack will call ndo_open(), kernel oops will be triggered.

Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 84936626

drivers/net/wireless/ath/wil6210/main.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -223,6 +223,11 @@ static void wil_fw_error_worker(struct work_struct *work)

		wil_dbg_misc(wil, "fw error worker\n");

		if (!netif_running(wil_to_ndev(wil))) {
		wil_info(wil, "No recovery - interface is down\n");
		return;
		}

		/* increment @recovery_count if less then WIL6210_FW_RECOVERY_TO
		* passed since last recovery attempt
		*/

Admin message