Commit cded19f3 authored by Hannes Eder's avatar Hannes Eder Committed by Avi Kivity
Browse files

KVM: fix sparse warnings: Should it be static? 



Impact: Make symbols static.

Fix this sparse warnings:
  arch/x86/kvm/mmu.c:992:5: warning: symbol 'mmu_pages_add' was not declared. Should it be static?
  arch/x86/kvm/mmu.c:1124:5: warning: symbol 'mmu_pages_next' was not declared. Should it be static?
  arch/x86/kvm/mmu.c:1144:6: warning: symbol 'mmu_pages_clear_parents' was not declared. Should it be static?
  arch/x86/kvm/x86.c:2037:5: warning: symbol 'kvm_read_guest_virt' was not declared. Should it be static?
  arch/x86/kvm/x86.c:2067:5: warning: symbol 'kvm_write_guest_virt' was not declared. Should it be static?
  virt/kvm/irq_comm.c:220:5: warning: symbol 'setup_routing_entry' was not declared. Should it be static?

Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
parent d7364a29

arch/x86/kvm/mmu.c

+6 −5
Original line number Diff line number Diff line
@@ -989,7 +989,7 @@ struct kvm_mmu_pages { 
	     idx < 512;					\

	     idx = find_next_bit(bitmap, 512, idx+1))



int mmu_pages_add(struct kvm_mmu_pages *pvec, struct kvm_mmu_page *sp,

static int mmu_pages_add(struct kvm_mmu_pages *pvec, struct kvm_mmu_page *sp,

			 int idx)

{

	int i;
@@ -1121,7 +1121,8 @@ struct mmu_page_path { 
			i < pvec.nr && ({ sp = pvec.page[i].sp; 1;});	\

			i = mmu_pages_next(&pvec, &parents, i))



int mmu_pages_next(struct kvm_mmu_pages *pvec, struct mmu_page_path *parents,

static int mmu_pages_next(struct kvm_mmu_pages *pvec,

			  struct mmu_page_path *parents,

			  int i)

{

	int n;
@@ -1141,7 +1142,7 @@ int mmu_pages_next(struct kvm_mmu_pages *pvec, struct mmu_page_path *parents, 
	return n;

}



void mmu_pages_clear_parents(struct mmu_page_path *parents)

static void mmu_pages_clear_parents(struct mmu_page_path *parents)

{

	struct kvm_mmu_page *sp;

	unsigned int level = 0;

arch/x86/kvm/x86.c

+4 −4
Original line number Diff line number Diff line
@@ -2043,7 +2043,7 @@ static struct kvm_io_device *vcpu_find_mmio_dev(struct kvm_vcpu *vcpu, 
	return dev;

}



int kvm_read_guest_virt(gva_t addr, void *val, unsigned int bytes,

static int kvm_read_guest_virt(gva_t addr, void *val, unsigned int bytes,

			       struct kvm_vcpu *vcpu)

{

	void *data = val;
@@ -2073,7 +2073,7 @@ out: 
	return r;

}



int kvm_write_guest_virt(gva_t addr, void *val, unsigned int bytes,

static int kvm_write_guest_virt(gva_t addr, void *val, unsigned int bytes,

				struct kvm_vcpu *vcpu)

{

	void *data = val;

virt/kvm/irq_comm.c

+2 −2
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ void kvm_free_irq_routing(struct kvm *kvm) 
	__kvm_free_irq_routing(&kvm->irq_routing);

}



int setup_routing_entry(struct kvm_kernel_irq_routing_entry *e,

static int setup_routing_entry(struct kvm_kernel_irq_routing_entry *e,

			       const struct kvm_irq_routing_entry *ue)

{

	int r = -EINVAL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE