Commit cddd5648 authored Jul 06, 2020 by Huazhong Tan Committed by David S. Miller Jul 06, 2020

net: hns3: fix for mishandle of asserting VF reset fail



When asserts VF reset fail, flag HCLGEVF_STATE_CMD_DISABLE
and handshake status should not set, otherwise the retry will
fail. So adds a check for asserting VF reset and returns
directly when fails.

Fixes: ef5f8e50 ("net: hns3: stop handling command queue while resetting VF")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bb3d8668

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1793,6 +1793,11 @@ static int hclgevf_reset_prepare_wait(struct hclgevf_dev *hdev)
		if (hdev->reset_type == HNAE3_VF_FUNC_RESET) {
		hclgevf_build_send_msg(&send_msg, HCLGE_MBX_RESET, 0);
		ret = hclgevf_send_mbx_msg(hdev, &send_msg, true, NULL, 0);
		if (ret) {
		dev_err(&hdev->pdev->dev,
		"failed to assert VF reset, ret = %d\n", ret);
		return ret;
		}
		hdev->rst_stats.vf_func_rst_cnt++;
		}

Admin message