btrfs: Fix kfree of member instead of structure (cddcd800) · Commits · 戴 / test

Correctness fix: The kfree calls in the add_delayed_* functions free the node that's passed into it, but the node is a member of another structure. It works because it's always the first member of the containing structure, but it should really be using the containing structure itself. Signed-off-by:

Jeff Mahoney <jeffm@suse.com>

fs/btrfs/delayed-ref.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -487,7 +487,7 @@ static noinline int add_delayed_ref_head(struct btrfs_fs_info *fs_info,
		* we've updated the existing ref, free the newly
		* allocated ref
		*/
		kfree(ref);
		kfree(head_ref);
		} else {
		delayed_refs->num_heads++;
		delayed_refs->num_heads_ready++;
		@@ -549,7 +549,7 @@ static noinline int add_delayed_tree_ref(struct btrfs_fs_info *fs_info,
		* we've updated the existing ref, free the newly
		* allocated ref
		*/
		kfree(ref);
		kfree(full_ref);
		} else {
		delayed_refs->num_entries++;
		trans->delayed_ref_updates++;
		@@ -611,7 +611,7 @@ static noinline int add_delayed_data_ref(struct btrfs_fs_info *fs_info,
		* we've updated the existing ref, free the newly
		* allocated ref
		*/
		kfree(ref);
		kfree(full_ref);
		} else {
		delayed_refs->num_entries++;
		trans->delayed_ref_updates++;

Admin message