usb: cdns3: Rids of duplicate error message (cdd3013d) · Commits · 戴 / test

On failure, the platform_get_irq_byname prints an error message, so patch removes error message related to this function from core.c file. A change was suggested during reviewing CDNSP driver by Chunfeng Yun. Acked-by:

Roger Quadros <rogerq@ti.com> Signed-off-by:

Pawel Laszczak <pawell@cadence.com> Acked-by:

Peter Chen <peter.chen@nxp.com> Signed-off-by:

Peter Chen <peter.chen@nxp.com>

drivers/usb/cdns3/core.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -466,11 +466,8 @@ static int cdns3_probe(struct platform_device *pdev)
		cdns->xhci_res[1] = *res;

		cdns->dev_irq = platform_get_irq_byname(pdev, "peripheral");
		if (cdns->dev_irq == -EPROBE_DEFER)
		return cdns->dev_irq;

		if (cdns->dev_irq < 0)
		dev_err(dev, "couldn't get peripheral irq\n");
		return cdns->dev_irq;

		regs = devm_platform_ioremap_resource_byname(pdev, "dev");
		if (IS_ERR(regs))
		@@ -478,14 +475,9 @@ static int cdns3_probe(struct platform_device *pdev)
		cdns->dev_regs = regs;

		cdns->otg_irq = platform_get_irq_byname(pdev, "otg");
		if (cdns->otg_irq == -EPROBE_DEFER)
		if (cdns->otg_irq < 0)
		return cdns->otg_irq;

		if (cdns->otg_irq < 0) {
		dev_err(dev, "couldn't get otg irq\n");
		return cdns->otg_irq;
		}

		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "otg");
		if (!res) {
		dev_err(dev, "couldn't get otg resource\n");

Admin message