Commit cdcf1121 authored by Rana Shahout's avatar Rana Shahout Committed by David S. Miller
Browse files

net/mlx5e: Validate BW weight values of ETS 



Valid weight assigned to ETS TClass values are 1-100

Fixes: 08fb1dac ('net/mlx5e: Support DCBNL IEEE ETS')
Signed-off-by: default avatarRana Shahout <ranas@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7ccdd084

drivers/net/ethernet/mellanox/mlx5/core/en.h

+0 −1
Original line number Diff line number Diff line
@@ -145,7 +145,6 @@ struct mlx5e_umr_wqe { 


#ifdef CONFIG_MLX5_CORE_EN_DCB

#define MLX5E_MAX_BW_ALLOC 100 /* Max percentage of BW allocation */

#define MLX5E_MIN_BW_ALLOC 1   /* Min percentage of BW allocation */

#endif



struct mlx5e_params {

drivers/net/ethernet/mellanox/mlx5/core/en_dcbnl.c

+6 −2
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ static void mlx5e_build_tc_tx_bw(struct ieee_ets *ets, u8 *tc_tx_bw, 
			tc_tx_bw[i] = MLX5E_MAX_BW_ALLOC;

			break;

		case IEEE_8021QAZ_TSA_ETS:

			tc_tx_bw[i] = ets->tc_tx_bw[i] ?: MLX5E_MIN_BW_ALLOC;

			tc_tx_bw[i] = ets->tc_tx_bw[i];

			break;

		}

	}
@@ -140,9 +140,13 @@ static int mlx5e_dbcnl_validate_ets(struct ieee_ets *ets) 


	/* Validate Bandwidth Sum */

	for (i = 0; i < IEEE_8021QAZ_MAX_TCS; i++) {

		if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_ETS)

		if (ets->tc_tsa[i] == IEEE_8021QAZ_TSA_ETS) {

			if (!ets->tc_tx_bw[i])

				return -EINVAL;



			bw_sum += ets->tc_tx_bw[i];

		}

	}



	if (bw_sum != 0 && bw_sum != 100)

		return -EINVAL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE