fs/adfs: dir: switch to iterate_shared method (cdc46e99) · Commits · 戴 / test

There is nothing in our readdir (aka iterate) method that relies on the directory inode being exclusively locked, so switch to using the iterate_shared() hook rather than iterate(). Signed-off-by:

Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by:

Al Viro <viro@zeniv.linux.org.uk>

fs/adfs/dir.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -235,8 +235,7 @@ void adfs_object_fixup(struct adfs_dir dir, struct object_info obj)
		}
		}

		static int
		adfs_readdir(struct file file, struct dir_context ctx)
		static int adfs_iterate(struct file file, struct dir_context ctx)
		{
		struct inode *inode = file_inode(file);
		struct super_block *sb = inode->i_sb;
		@@ -399,7 +398,7 @@ unlock:
		const struct file_operations adfs_dir_operations = {
		.read = generic_read_dir,
		.llseek = generic_file_llseek,
		.iterate = adfs_readdir,
		.iterate_shared = adfs_iterate,
		.fsync = generic_file_fsync,
		};

Admin message