Commit cdbeb315 authored by Philipp Zabel's avatar Philipp Zabel
Browse files

reset: socfpga: declare socfpga_reset_init in a header file 



Avoid declaring extern functions in c files. To make sure function
definition and usage don't get out of sync, declare socfpga_reset_init
in a common header.

Suggested-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Acked-by: default avatarDinh Nguyen <dinguyen@kernel.org>
parent fdce6078

arch/arm/mach-socfpga/socfpga.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -19,6 +19,7 @@ 
#include <linux/of_irq.h>

#include <linux/of_irq.h>

#include <linux/of_platform.h>

#include <linux/of_platform.h>

#include <linux/reboot.h>

#include <linux/reboot.h>

#include <linux/reset/socfpga.h>





#include <asm/hardware/cache-l2x0.h>

#include <asm/hardware/cache-l2x0.h>

#include <asm/mach/arch.h>

#include <asm/mach/arch.h>
@@ -32,8 +33,6 @@ void __iomem *rst_manager_base_addr; 
void __iomem *sdr_ctl_base_addr;

void __iomem *sdr_ctl_base_addr;

unsigned long socfpga_cpu1start_addr;

unsigned long socfpga_cpu1start_addr;





extern void __init socfpga_reset_init(void);



static void __init socfpga_sysmgr_init(void)

static void __init socfpga_sysmgr_init(void)

{

{

	struct device_node *np;

	struct device_node *np;

drivers/reset/reset-socfpga.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -11,6 +11,7 @@ 
#include <linux/of_address.h>

#include <linux/of_address.h>

#include <linux/platform_device.h>

#include <linux/platform_device.h>

#include <linux/reset-controller.h>

#include <linux/reset-controller.h>

#include <linux/reset/socfpga.h>

#include <linux/slab.h>

#include <linux/slab.h>

#include <linux/spinlock.h>

#include <linux/spinlock.h>

#include <linux/types.h>

#include <linux/types.h>
@@ -18,7 +19,6 @@ 
#include "reset-simple.h"

#include "reset-simple.h"





#define SOCFPGA_NR_BANKS	8

#define SOCFPGA_NR_BANKS	8

void __init socfpga_reset_init(void);





static int a10_reset_init(struct device_node *np)

static int a10_reset_init(struct device_node *np)

{

{

include/linux/reset/socfpga.h

0 → 100644
+7 −0
Original line number Original line Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

#ifndef __LINUX_RESET_SOCFPGA_H__

#define __LINUX_RESET_SOCFPGA_H__



void __init socfpga_reset_init(void);



#endif /* __LINUX_RESET_SOCFPGA_H__ */

CRA Git | Maintained and supported by SUSTech CRA and CCSE