Commit cd96891d authored by Randy Dunlap's avatar Randy Dunlap Committed by Linus Torvalds
Browse files

sched/fair: fix lots of kernel-doc warnings 



Fix lots of new kernel-doc warnings in kernel/sched/fair.c:

  Warning(kernel/sched/fair.c:3625): No description found for parameter 'env'
  Warning(kernel/sched/fair.c:3625): Excess function parameter 'sd' description in 'update_sg_lb_stats'
  Warning(kernel/sched/fair.c:3735): No description found for parameter 'env'
  Warning(kernel/sched/fair.c:3735): Excess function parameter 'sd' description in 'update_sd_pick_busiest'
  Warning(kernel/sched/fair.c:3735): Excess function parameter 'this_cpu' description in 'update_sd_pick_busiest'
  .. more warnings

Signed-off-by: default avatarRandy Dunlap <rdunlap@xenotime.net>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 8f53369b

kernel/sched/fair.c

+6 −16
Original line number Original line Diff line number Diff line
@@ -3632,7 +3632,7 @@ fix_small_capacity(struct sched_domain *sd, struct sched_group *group) 




/**

/**

 * update_sg_lb_stats - Update sched_group's statistics for load balancing.

 * update_sg_lb_stats - Update sched_group's statistics for load balancing.

 * @sd: The sched_domain whose statistics are to be updated.

 * @env: The load balancing environment.

 * @group: sched_group whose statistics are to be updated.

 * @group: sched_group whose statistics are to be updated.

 * @load_idx: Load index of sched_domain of this_cpu for load calc.

 * @load_idx: Load index of sched_domain of this_cpu for load calc.

 * @local_group: Does group contain this_cpu.

 * @local_group: Does group contain this_cpu.
@@ -3741,11 +3741,10 @@ static inline void update_sg_lb_stats(struct lb_env *env, 




/**

/**

 * update_sd_pick_busiest - return 1 on busiest group

 * update_sd_pick_busiest - return 1 on busiest group

 * @sd: sched_domain whose statistics are to be checked

 * @env: The load balancing environment.

 * @sds: sched_domain statistics

 * @sds: sched_domain statistics

 * @sg: sched_group candidate to be checked for being the busiest

 * @sg: sched_group candidate to be checked for being the busiest

 * @sgs: sched_group statistics

 * @sgs: sched_group statistics

 * @this_cpu: the current cpu

 *

 *

 * Determine if @sg is a busier group than the previously selected

 * Determine if @sg is a busier group than the previously selected

 * busiest group.

 * busiest group.
@@ -3783,9 +3782,7 @@ static bool update_sd_pick_busiest(struct lb_env *env, 




/**

/**

 * update_sd_lb_stats - Update sched_domain's statistics for load balancing.

 * update_sd_lb_stats - Update sched_domain's statistics for load balancing.

 * @sd: sched_domain whose statistics are to be updated.

 * @env: The load balancing environment.

 * @this_cpu: Cpu for which load balance is currently performed.

 * @idle: Idle status of this_cpu

 * @cpus: Set of cpus considered for load balancing.

 * @cpus: Set of cpus considered for load balancing.

 * @balance: Should we balance.

 * @balance: Should we balance.

 * @sds: variable to hold the statistics for this sched_domain.

 * @sds: variable to hold the statistics for this sched_domain.
@@ -3874,10 +3871,8 @@ static inline void update_sd_lb_stats(struct lb_env *env, 
 * Returns 1 when packing is required and a task should be moved to

 * Returns 1 when packing is required and a task should be moved to

 * this CPU.  The amount of the imbalance is returned in *imbalance.

 * this CPU.  The amount of the imbalance is returned in *imbalance.

 *

 *

 * @sd: The sched_domain whose packing is to be checked.

 * @env: The load balancing environment.

 * @sds: Statistics of the sched_domain which is to be packed

 * @sds: Statistics of the sched_domain which is to be packed

 * @this_cpu: The cpu at whose sched_domain we're performing load-balance.

 * @imbalance: returns amount of imbalanced due to packing.

 */

 */

static int check_asym_packing(struct lb_env *env, struct sd_lb_stats *sds)

static int check_asym_packing(struct lb_env *env, struct sd_lb_stats *sds)

{

{
@@ -3903,9 +3898,8 @@ static int check_asym_packing(struct lb_env *env, struct sd_lb_stats *sds) 
 * fix_small_imbalance - Calculate the minor imbalance that exists

 * fix_small_imbalance - Calculate the minor imbalance that exists

 *			amongst the groups of a sched_domain, during

 *			amongst the groups of a sched_domain, during

 *			load balancing.

 *			load balancing.

 * @env: The load balancing environment.

 * @sds: Statistics of the sched_domain whose imbalance is to be calculated.

 * @sds: Statistics of the sched_domain whose imbalance is to be calculated.

 * @this_cpu: The cpu at whose sched_domain we're performing load-balance.

 * @imbalance: Variable to store the imbalance.

 */

 */

static inline

static inline

void fix_small_imbalance(struct lb_env *env, struct sd_lb_stats *sds)

void fix_small_imbalance(struct lb_env *env, struct sd_lb_stats *sds)
@@ -4048,11 +4042,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s 
 * Also calculates the amount of weighted load which should be moved

 * Also calculates the amount of weighted load which should be moved

 * to restore balance.

 * to restore balance.

 *

 *

 * @sd: The sched_domain whose busiest group is to be returned.

 * @env: The load balancing environment.

 * @this_cpu: The cpu for which load balancing is currently being performed.

 * @imbalance: Variable which stores amount of weighted load which should

 *		be moved to restore balance/put a group to idle.

 * @idle: The idle status of this_cpu.

 * @cpus: The set of CPUs under consideration for load-balancing.

 * @cpus: The set of CPUs under consideration for load-balancing.

 * @balance: Pointer to a variable indicating if this_cpu

 * @balance: Pointer to a variable indicating if this_cpu

 *	is the appropriate cpu to perform load balancing at this_level.

 *	is the appropriate cpu to perform load balancing at this_level.

CRA Git | Maintained and supported by SUSTech CRA and CCSE