[PATCH] ext3: fix nobh mode for chattr +j inodes (cd6ef84e) · Commits · 戴 / test

One can do "chattr +j" on a file to change its journalling mode. Fix writeback mode with "nobh" handling for it. Even though, we mount ext3 filesystem in writeback mode with "nobh" option, some one can do "chattr +j" on a single file to force it to do journalled mode. In order to do journaling, ext3_block_truncate_page() need to fallback to default case of creating buffers and adding them to transaction etc. Signed-off-by:

Badari Pulavarty <pbadari@us.ibm.com> Signed-off-by:

Andrew Morton <akpm@osdl.org> Signed-off-by:

Linus Torvalds <torvalds@osdl.org>

fs/ext3/inode.c

+8 −9

Original line number	Diff line number	Diff line
		@@ -1624,8 +1624,8 @@ static int ext3_block_truncate_page(handle_t handle, struct page page,
		* For "nobh" option, we can only work if we don't need to
		* read-in the page - otherwise we create buffers to do the IO.
		*/
		if (!page_has_buffers(page) && test_opt(inode->i_sb, NOBH)) {
		if (PageUptodate(page)) {
		if (!page_has_buffers(page) && test_opt(inode->i_sb, NOBH) &&
		ext3_should_writeback_data(inode) && PageUptodate(page)) {
		kaddr = kmap_atomic(page, KM_USER0);
		memset(kaddr + offset, 0, length);
		flush_dcache_page(page);
		@@ -1633,7 +1633,6 @@ static int ext3_block_truncate_page(handle_t handle, struct page page,
		set_page_dirty(page);
		goto unlock;
		}
		}

		if (!page_has_buffers(page))
		create_empty_buffers(page, blocksize, 0);

Admin message