Commit cd63a894 authored by Lee Jones's avatar Lee Jones
Browse files

mfd: ab3100-core: Correct code sytle problems 



Corrects the following checkpatch gripes:

    WARNING: quoted string split across lines
    #95: FILE: drivers/mfd/ab3100-core.c:95:
    +			"write error (write register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: quoted string split across lines
    #139: FILE: drivers/mfd/ab3100-core.c:139:
    +			"write error (write test register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: quoted string split across lines
    #175: FILE: drivers/mfd/ab3100-core.c:175:
    +			"write error (send register address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #193: FILE: drivers/mfd/ab3100-core.c:193:
    +			"write error (read register) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #241: FILE: drivers/mfd/ab3100-core.c:241:
    +			"write error (send first register address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #256: FILE: drivers/mfd/ab3100-core.c:256:
    +			"write error (read register page) "
    +			"%d bytes transferred (expected %d)\n",

    WARNING: quoted string split across lines
    #299: FILE: drivers/mfd/ab3100-core.c:299:
    +			"write error (maskset send address) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #314: FILE: drivers/mfd/ab3100-core.c:314:
    +			"write error (maskset read register) "
    +			"%d bytes transferred (expected 1)\n",

    WARNING: quoted string split across lines
    #334: FILE: drivers/mfd/ab3100-core.c:334:
    +			"write error (write register) "
    +			"%d bytes transferred (expected 2)\n",

    WARNING: please, no spaces at the start of a line
    #374: FILE: drivers/mfd/ab3100-core.c:374:
    +  return blocking_notifier_chain_unregister(&ab3100->event_subscribers,$

    WARNING: Prefer seq_puts to seq_printf
    #458: FILE: drivers/mfd/ab3100-core.c:458:
    +	seq_printf(s, "AB3100 registers:\n");

    WARNING: quoted string split across lines
    #564: FILE: drivers/mfd/ab3100-core.c:564:
    +			 "debug write reg[0x%02x] with 0x%02x, "
    +			 "after readback: 0x%02x\n",

    WARNING: quoted string split across lines
    #723: FILE: drivers/mfd/ab3100-core.c:723:
    +			 "AB3100 P1E variant detected, "
    +			 "forcing chip to 32KHz\n");

    WARNING: quoted string split across lines
    #882: FILE: drivers/mfd/ab3100-core.c:882:
    +			"could not communicate with the AB3100 analog "
    +			"baseband chip\n");

    WARNING: quoted string split across lines
    #906: FILE: drivers/mfd/ab3100-core.c:906:
    +		dev_err(&client->dev, "accepting it anyway. Please update "
    +			"the driver.\n");

    total: 0 errors, 15 warnings, 999 lines checked

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 0ebc1c25

drivers/mfd/ab3100-core.c

+26 −28
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ static int ab3100_set_register_interruptible(struct ab3100 *ab3100, 
			err);

	} else if (err != 2) {

		dev_err(ab3100->dev,

			"write error (write register) "

			"write error (write register)\n"

			"  %d bytes transferred (expected 2)\n",

			err);

		err = -EIO;
@@ -135,7 +135,7 @@ static int ab3100_set_test_register_interruptible(struct ab3100 *ab3100, 
			err);

	} else if (err != 2) {

		dev_err(ab3100->dev,

			"write error (write test register) "

			"write error (write test register)\n"

			"  %d bytes transferred (expected 2)\n",

			err);

		err = -EIO;
@@ -171,7 +171,7 @@ static int ab3100_get_register_interruptible(struct ab3100 *ab3100, 
		goto get_reg_out_unlock;

	} else if (err != 1) {

		dev_err(ab3100->dev,

			"write error (send register address) "

			"write error (send register address)\n"

			"  %d bytes transferred (expected 1)\n",

			err);

		err = -EIO;
@@ -189,7 +189,7 @@ static int ab3100_get_register_interruptible(struct ab3100 *ab3100, 
		goto get_reg_out_unlock;

	} else if (err != 1) {

		dev_err(ab3100->dev,

			"write error (read register) "

			"write error (read register)\n"

			"  %d bytes transferred (expected 1)\n",

			err);

		err = -EIO;
@@ -237,7 +237,7 @@ static int ab3100_get_register_page_interruptible(struct ab3100 *ab3100, 
		goto get_reg_page_out_unlock;

	} else if (err != 1) {

		dev_err(ab3100->dev,

			"write error (send first register address) "

			"write error (send first register address)\n"

			"  %d bytes transferred (expected 1)\n",

			err);

		err = -EIO;
@@ -252,7 +252,7 @@ static int ab3100_get_register_page_interruptible(struct ab3100 *ab3100, 
		goto get_reg_page_out_unlock;

	} else if (err != numregs) {

		dev_err(ab3100->dev,

			"write error (read register page) "

			"write error (read register page)\n"

			"  %d bytes transferred (expected %d)\n",

			err, numregs);

		err = -EIO;
@@ -295,7 +295,7 @@ static int ab3100_mask_and_set_register_interruptible(struct ab3100 *ab3100, 
		goto get_maskset_unlock;

	} else if (err != 1) {

		dev_err(ab3100->dev,

			"write error (maskset send address) "

			"write error (maskset send address)\n"

			"  %d bytes transferred (expected 1)\n",

			err);

		err = -EIO;
@@ -310,7 +310,7 @@ static int ab3100_mask_and_set_register_interruptible(struct ab3100 *ab3100, 
		goto get_maskset_unlock;

	} else if (err != 1) {

		dev_err(ab3100->dev,

			"write error (maskset read register) "

			"write error (maskset read register)\n"

			"  %d bytes transferred (expected 1)\n",

			err);

		err = -EIO;
@@ -330,7 +330,7 @@ static int ab3100_mask_and_set_register_interruptible(struct ab3100 *ab3100, 
		goto get_maskset_unlock;

	} else if (err != 2) {

		dev_err(ab3100->dev,

			"write error (write register) "

			"write error (write register)\n"

			"  %d bytes transferred (expected 2)\n",

			err);

		err = -EIO;
@@ -455,7 +455,7 @@ static int ab3100_registers_print(struct seq_file *s, void *p) 
	u8 value;

	u8 reg;



	seq_printf(s, "AB3100 registers:\n");

	seq_puts(s, "AB3100 registers:\n");



	for (reg = 0; reg < 0xff; reg++) {

		ab3100_get_register_interruptible(ab3100, reg, &value);
@@ -560,8 +560,8 @@ static ssize_t ab3100_get_set_reg(struct file *file, 
		ab3100_get_register_interruptible(ab3100, user_reg, &regvalue);



		dev_info(ab3100->dev,

			 "debug write reg[0x%02x] with 0x%02x, "

			 "after readback: 0x%02x\n",

			 "debug write reg[0x%02x]\n"

			 "  with 0x%02x, after readback: 0x%02x\n",

			 user_reg, user_value, regvalue);

	}

	return buf_size;
@@ -719,8 +719,7 @@ static int ab3100_setup(struct ab3100 *ab3100) 
	 */

	if (ab3100->chip_id == 0xc4) {

		dev_warn(ab3100->dev,

			 "AB3100 P1E variant detected, "

			 "forcing chip to 32KHz\n");

			 "AB3100 P1E variant detected forcing chip to 32KHz\n");

		err = ab3100_set_test_register_interruptible(ab3100,

			0x02, 0x08);

	}
@@ -878,8 +877,7 @@ static int ab3100_probe(struct i2c_client *client, 
						&ab3100->chip_id);

	if (err) {

		dev_err(&client->dev,

			"could not communicate with the AB3100 analog "

			"baseband chip\n");

			"failed to communicate with AB3100 chip\n");

		goto exit_no_detect;

	}
@@ -902,8 +900,8 @@ static int ab3100_probe(struct i2c_client *client, 
	if (ids[i].id == 0x0) {

		dev_err(&client->dev, "unknown analog baseband chip id: 0x%x\n",

			ab3100->chip_id);

		dev_err(&client->dev, "accepting it anyway. Please update "

			"the driver.\n");

		dev_err(&client->dev,

			"accepting it anyway. Please update the driver.\n");

		goto exit_no_detect;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE